-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Upgrade cert-manager to v1.1.0 #4013
⚠️ Upgrade cert-manager to v1.1.0 #4013
Conversation
/milestone v0.4.0 |
/milestone v0.4.0 |
@fabriziopandini What's left to do here? Could we also bring these changes to Kubebuilder? |
@vincepri from what I understood in kubebuilder this was already addressed by kubernetes-sigs/kubebuilder#1840 This PR is waiting for changes to webhook to land (#3985) before migrating certificates to the v1 version |
Reviewing 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also update our documentation.
https://cluster-api.sigs.k8s.io/developer/guide.html?highlight=cert-manage#cert-manager
In the link above, we are specifying v0.11.0
instead of v0.16.1
. This PR can update that to v1.1.0
.
3e3e2a4
to
a1a4cd4
Compare
/pull-cluster-api-e2e-full-main |
a1a4cd4
to
551a250
Compare
/retest |
@fabriziopandini |
/retest |
551a250
to
24926f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR updates the version of cert-manager from v0.16.1 to v1.1.0
Waiting for #3985 to change manifests
Which issue(s) this PR fixes:
Fixes #3996