Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Upgrade cert-manager to v1.1.0 #4013

Merged
merged 1 commit into from
Feb 8, 2021
Merged

⚠️ Upgrade cert-manager to v1.1.0 #4013

merged 1 commit into from
Feb 8, 2021

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR updates the version of cert-manager from v0.16.1 to v1.1.0

Waiting for #3985 to change manifests

Which issue(s) this PR fixes:
Fixes #3996

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 11, 2020
@fabriziopandini
Copy link
Member Author

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Dec 11, 2020
@fabriziopandini
Copy link
Member Author

/milestone v0.4.0

@vincepri
Copy link
Member

@fabriziopandini What's left to do here? Could we also bring these changes to Kubebuilder?

@fabriziopandini
Copy link
Member Author

@vincepri from what I understood in kubebuilder this was already addressed by kubernetes-sigs/kubebuilder#1840

This PR is waiting for changes to webhook to land (#3985) before migrating certificates to the v1 version

@wfernandes
Copy link
Contributor

Reviewing 👀

wfernandes
wfernandes reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@wfernandes wfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also update our documentation.
https://cluster-api.sigs.k8s.io/developer/guide.html?highlight=cert-manage#cert-manager
In the link above, we are specifying v0.11.0 instead of v0.16.1. This PR can update that to v1.1.0.

cmd/clusterctl/client/cluster/cert_manager.go Show resolved Hide resolved
docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2021
@fabriziopandini
Copy link
Member Author

/pull-cluster-api-e2e-full-main

@fabriziopandini
Copy link
Member Author

/retest

@vincepri
Copy link
Member

vincepri commented Feb 5, 2021

@fabriziopandini make generate needs to be updated

@fabriziopandini fabriziopandini changed the title [WIP] ⚠️ Upgrade cert-manager to v1.1.0 ⚠️ Upgrade cert-manager to v1.1.0 Feb 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2021
@fabriziopandini
Copy link
Member Author

/retest

vincepri
vincepri approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 886a167 into kubernetes-sigs:master Feb 8, 2021
@wfernandes wfernandes mentioned this pull request Feb 8, 2021
Closed
@fabriziopandini fabriziopandini deleted the upgrade-cert-manager-to-v1.1.0 branch February 10, 2021 13:39
This was referenced Feb 23, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfernandes wfernandes wfernandes left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@moshloop moshloop Awaiting requested review from moshloop

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Upgrade cert-manager to version 1.x
4 participants
@fabriziopandini @vincepri @wfernandes @k8s-ci-robot