Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete google specific code from the repository. #438

Merged

Conversation

roberthbailey
Copy link
Contributor

@roberthbailey roberthbailey commented Jul 23, 2018

What this PR does / why we need it: Now that the google code has been extracted into https://github.com/kubernetes-sigs/cluster-api-provider-gcp this PR removes it from the main repository.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #434

Special notes for your reviewer: The sooner the better so that we don't have to deal with drift between the two code locations.

Release note:

clusterctl no longer supports --provider google. To create a cluster on Google Cloud Platform, please use clusterctl from https://github.com/kubernetes-sigs/cluster-api-provider-gcp. 

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2018
@roberthbailey
Copy link
Contributor Author

/assign @dims @krousey @jessicaochen

@krousey
Copy link
Contributor

krousey commented Jul 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit 83ca2bc into kubernetes-sigs:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the cloud/google directory
5 participants