Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move clusterdeployer_test.go into clusterdeployer package #439

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Move clusterdeployer_test.go into clusterdeployer package #439

merged 3 commits into from
Jul 25, 2018

Commits on Jul 25, 2018

  1. Make clusterdeployer.go more testable 

    Move clusterdeployer_test into clusterdeployer package

Signed-off-by: Ashish Amarnath <ashish.amarnath@gmail.com>
    @ashish-amarnath
    ashish-amarnath committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    c33a09b View commit details
    Browse the repository at this point in the history

  2. * add tests for extractMasterMachine() 

    * remove unused PHONY make targets
    @ashish-amarnath
    ashish-amarnath committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    320a632 View commit details
    Browse the repository at this point in the history

  3. Address code-review comments 

    * follow style guidelines for test failure messages
* set fields in test data using initializers
* refactor to simplify test data generation
    @ashish-amarnath
    ashish-amarnath committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    1ed0be2 View commit details
    Browse the repository at this point in the history