-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete vsphere specific code from the repository. #440
Delete vsphere specific code from the repository. #440
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @krousey @frapposelli @dims |
@roberthbailey: GitHub didn't allow me to assign the following users: frapposelli. Note that only kubernetes-sigs members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm Did you check to see if we could clean up the vendor directory after this? I doubt it, but just want to verify. |
Yes, I ran |
What this PR does / why we need it: This PR removes the vsphere specific code from the main repository. While a new repository has not yet been created, as described in #427 (comment) I've copied all relevant files with history into https://github.com/roberthbailey/cluster-api-provider-vsphere so that a provider specific repository can be created.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #435
Special notes for your reviewer:
Release note: