-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rbac] There are roles missing in the clusterapiservertemplate file. #462
[rbac] There are roles missing in the clusterapiservertemplate file. #462
Conversation
…ke apiserver work.
Should common code make assumptions about cluster-scoped resources (e.g. Even still, I tend to favor merging this, or some other common code which providers can share. Each provider shouldn't have to create this |
@davidewatson - embedding this yaml inside the code probably isn't a great idea long term, but for now I think it makes sense to make the role bindings correct. Any objections to merging this? |
/assign @davidewatson |
@roberthbailey: GitHub didn't allow me to assign the following users: davidewatson. Note that only kubernetes-sigs members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@roberthbailey: lgtm, thanks! |
/lgtm |
@davidewatson: changing LGTM is restricted to assignees, and only kubernetes-sigs/cluster-api repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejandroEsc, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Create base images for bootstrap and manifests
What this PR does / why we need it: Some cluster role bindings were missing as suggested in https://github.com/kubernetes-incubator/apiserver-builder/blob/master/docs/concepts/auth.md.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: