Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rbac] There are roles missing in the clusterapiservertemplate file. #462

Merged

Conversation

alejandroEsc
Copy link
Contributor

What this PR does / why we need it: Some cluster role bindings were missing as suggested in https://github.com/kubernetes-incubator/apiserver-builder/blob/master/docs/concepts/auth.md.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

missing rbac resources added to apiserverclusterapiservertemplate file.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 27, 2018
@davidewatson
Copy link
Contributor

davidewatson commented Jul 27, 2018

Should common code make assumptions about cluster-scoped resources (e.g. ClusterRoles, Namespacess, etc.)? Maybe not.

Even still, I tend to favor merging this, or some other common code which providers can share. Each provider shouldn't have to create this ClusterRoleBinding...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2018
@roberthbailey
Copy link
Contributor

@davidewatson - embedding this yaml inside the code probably isn't a great idea long term, but for now I think it makes sense to make the role bindings correct. Any objections to merging this?

@roberthbailey roberthbailey self-assigned this Jul 27, 2018
@roberthbailey
Copy link
Contributor

/assign @davidewatson

@k8s-ci-robot
Copy link
Contributor

@roberthbailey: GitHub didn't allow me to assign the following users: davidewatson.

Note that only kubernetes-sigs members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @davidewatson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidewatson
Copy link
Contributor

@roberthbailey: lgtm, thanks!

@davidewatson
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@davidewatson: changing LGTM is restricted to assignees, and only kubernetes-sigs/cluster-api repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandroEsc, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit fdbcdd0 into kubernetes-sigs:master Jul 27, 2018
@alejandroEsc alejandroEsc deleted the ae/deployer/template/roles branch July 27, 2018 23:02
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
Create base images for bootstrap and manifests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants