Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update controller runtime to v0.9.0-beta.5 #4638

Merged
merged 1 commit into from
May 19, 2021

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented May 19, 2021

What this PR does / why we need it:

This change fixes a bug where the conversion webhooks were not actually
being registered and running with envtest.

Related CR PR: kubernetes-sigs/controller-runtime#1532

/milestone v0.4
/area dependency

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone May 19, 2021
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 19, 2021
@enxebre
Copy link
Member

enxebre commented May 19, 2021

nit: it'd be nice to add a link to the relevant controller runtime issue/PR in the PR desc

@vincepri vincepri changed the title 🌱 Update controller runtime to v0.9.0-beta.4 🌱 Update controller runtime to v0.9.0-beta.5 May 19, 2021
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@fabriziopandini
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@vincepri
Copy link
Member Author

/hold

for next release

@sbueringer
Copy link
Member

@vincepri just a ping which is at least a bit related with controller-runtime and which version we will use in our release.
Are you aware of: kubernetes-sigs/controller-runtime#1520 ?
I think we definitely need this fix in our release.

@vincepri
Copy link
Member Author

@sbueringer Wasn't aware of that PR, although it seems it has stalled a bit

@sbueringer
Copy link
Member

sbueringer commented May 19, 2021

@vincepri Yup, problem is, if this isn't fixed, controller runtime sends requests for a _cluster-scope namespace (details here: kubernetes-sigs/controller-runtime#1418 (comment)) to the APIServer, which is a pretty bad bug. Especially when RBAC is tuned for per-namespace access, because then the controller fails on start.

Oh, I just realized that we are not using MultiNamespaceCache, I though we were. Okay so then we're not affected by this bug.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@vincepri
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@vincepri
Copy link
Member Author

/retest

This change fixes a bug where the conversion webhooks were not actually
being registered and running with envtest.

Signed-off-by: Vince Prignano <vincepri@vmware.com>
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit f5dec18 into kubernetes-sigs:master May 19, 2021
enxebre pushed a commit to enxebre/cluster-api that referenced this pull request May 24, 2021
🌱 Update controller runtime to v0.9.0-beta.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants