Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Introduce Kubeadm v1beta3 #4691

Merged
merged 3 commits into from
May 28, 2021
Merged

🌱 Introduce Kubeadm v1beta3 #4691

merged 3 commits into from
May 28, 2021

Conversation

shysank
Copy link
Contributor

@shysank shysank commented May 27, 2021

What this PR does / why we need it:

With v1beta3 merged in Kubeadm, this pr introduces v1beta3 to bootstrap/kubeadm types with all the scaffolding.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4445

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 27, 2021
@vincepri
Copy link
Member

LGTM apart from the linter errors and verification job

/assign @fabriziopandini @CecileRobertMichon

@shysank shysank force-pushed the kubeadm_v1beta3 branch from 2972596 to ec0e680 Compare May 27, 2021 19:42
@shysank shysank force-pushed the kubeadm_v1beta3 branch from ec0e680 to da31f6b Compare May 27, 2021 20:24
@shysank
Copy link
Contributor Author

shysank commented May 27, 2021

/test pull-cluster-api-test-main

fabriziopandini
fabriziopandini reviewed May 27, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending two small nits

bootstrap/kubeadm/types/utils.go Outdated Show resolved Hide resolved
bootstrap/kubeadm/types/utils_test.go Show resolved Hide resolved
@shysank shysank force-pushed the kubeadm_v1beta3 branch from da31f6b to bc07b93 Compare May 27, 2021 21:38
@CecileRobertMichon
Copy link
Contributor

Do we have a k8s 1.22 (or k8s HEAD) test running as part of this PR? It'd be good if we have a way to run k8s main conformance to validate changes like these similar to the ones we have in CAPA/CAPZ/soon CAPO

@neolit123
Copy link
Member

neolit123 commented May 28, 2021 •
edited
Loading

Fixes #4445

having the v1beta3 here as a placeholder seems fine, but should it be updated once kubeadm work on v1beta3 finishes with the 1.22 release - i.e. fields are added / removed?

@fabriziopandini
Copy link
Member

Do we have a k8s 1.22 (or k8s HEAD) test running as part of this PR?

Yes, it is one of our PR optional jobs (in addition to a periodic periodic job).

/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

having the v1beta3 here as a placeholder seems fine, but should it be updated once kubeadm work on v1beta3 finishes with the 1.22 release - i.e. fields are added / removed?

Of course, but without this our tests are failing

@fabriziopandini
Copy link
Member

/retest

@fabriziopandini
Copy link
Member

/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
vincepri
vincepri approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/kind release-blocking

@k8s-ci-robot k8s-ci-robot added the kind/release-blocking Issues or PRs that need to be closed before the next CAPI release label May 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit c9f1dac into kubernetes-sigs:master May 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Implement support for kubeadm v1beta3 types
6 participants
@shysank @vincepri @CecileRobertMichon @neolit123 @fabriziopandini @k8s-ci-robot