[clusterctl] Rename external to bootstrap and internal to target #484
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -37,14 +37,15 @@ func NewExternalCluster(kubeconfigPath string) (*ExternalBootstrapCluster, error | |||
| return nil, fmt.Errorf("file at %s does not exist", kubeconfigPath) | |||
| } | |||
|
|
|||
| return &ExternalBootstrapCluster{kubeconfigPath:kubeconfigPath}, nil | |||
| return &ExternalBootstrapCluster{kubeconfigPath: kubeconfigPath}, nil | |||
There was a problem hiding this comment.
Are we leaving this as "ExternalBootstrap" because we also expect to have a different type of FooBoootstrap in the future? Or is that redundant and we should just call this "BootstrapCluster"?
There was a problem hiding this comment.
I did a bit of re-organization and renaming to help clear it up.
| glog.Info("Creating external cluster") | ||
| externalClient, cleanupExternalCluster, err := d.createExternalCluster() | ||
| defer cleanupExternalCluster() | ||
| glog.Info("Creating bootstrap client") |
There was a problem hiding this comment.
I'm torn about saying client here vs. cluster. In some cases, it will just be a client (to an existing cluster) but the default (at least today) is to actually create a cluster, in which case saying it this way will be confusing to users.
| externalClient, cleanupExternalCluster, err := d.createExternalCluster() | ||
| defer cleanupExternalCluster() | ||
| func (d *ClusterDeployer) Delete(targetClient ClusterClient) error { | ||
| glog.Info("Creating bootstrap cluster") |
There was a problem hiding this comment.
Here you left it as "cluster" instead of "client"
- Rename references to "external" cluster to "bootstrap" - Rename references to "internal" cluster to "target" - Rename ExternalBootstrapCluster to ExistingCluster
detiber
force-pushed
the
externalToBootstrap
branch
from
483a60f
to
3530b8c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…pdate moved preferredAPIServerCidr in troubleshooting doc to correct line
What this PR does / why we need it:
Per the discussion during the cluster-api working group meeting the usage of external/internal to reference clusters within clusterctl is confusing. This PR updates changes to using bootstrap and target instead.
Release note: