-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clusterctl] Rename external to bootstrap and internal to target #484
[clusterctl] Rename external to bootstrap and internal to target #484
Conversation
@@ -37,14 +37,15 @@ func NewExternalCluster(kubeconfigPath string) (*ExternalBootstrapCluster, error | |||
return nil, fmt.Errorf("file at %s does not exist", kubeconfigPath) | |||
} | |||
|
|||
return &ExternalBootstrapCluster{kubeconfigPath:kubeconfigPath}, nil | |||
return &ExternalBootstrapCluster{kubeconfigPath: kubeconfigPath}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we leaving this as "ExternalBootstrap" because we also expect to have a different type of FooBoootstrap in the future? Or is that redundant and we should just call this "BootstrapCluster"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a bit of re-organization and renaming to help clear it up.
glog.Info("Creating external cluster") | ||
externalClient, cleanupExternalCluster, err := d.createExternalCluster() | ||
defer cleanupExternalCluster() | ||
glog.Info("Creating bootstrap client") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm torn about saying client here vs. cluster. In some cases, it will just be a client (to an existing cluster) but the default (at least today) is to actually create a cluster, in which case saying it this way will be confusing to users.
externalClient, cleanupExternalCluster, err := d.createExternalCluster() | ||
defer cleanupExternalCluster() | ||
func (d *ClusterDeployer) Delete(targetClient ClusterClient) error { | ||
glog.Info("Creating bootstrap cluster") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you left it as "cluster" instead of "client"
- Rename references to "external" cluster to "bootstrap" - Rename references to "internal" cluster to "target" - Rename ExternalBootstrapCluster to ExistingCluster
483a60f
to
3530b8c
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pdate moved preferredAPIServerCidr in troubleshooting doc to correct line
What this PR does / why we need it:
Per the discussion during the cluster-api working group meeting the usage of external/internal to reference clusters within clusterctl is confusing. This PR updates changes to using bootstrap and target instead.
Release note: