CLI param to proxy minikube's options #485
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-cluster-api-test |
| @@ -28,14 +28,15 @@ import ( | |||
| type Minikube struct { | |||
| kubeconfigpath string | |||
| vmDriver string | |||
| options []string | |||
There was a problem hiding this comment.
please run gofmt on this file.
| @@ -28,14 +28,15 @@ import ( | |||
| type Minikube struct { | |||
| kubeconfigpath string | |||
| vmDriver string | |||
There was a problem hiding this comment.
should vmDriver be removed (is it being replaced by options)?
| // minikubeExec implemented as function variable for testing hooks | ||
| minikubeExec func(env []string, args ...string) (string, error) | ||
| } | ||
|
|
||
| func New(vmDriver string) *Minikube { | ||
| func New(options []string) *Minikube { |
There was a problem hiding this comment.
If these are purely optional, it would be nice to make them optional. Maybe two constructors: New() and WithOptions(options []string) would make more sense (and make the test code easier to read)?
Client code would look like either m := minikube.New() or m := minikube.WithOptions([]string{"vm-driver=kvm2"}) which I think would be easier to read than m := New([]string{}).
There was a problem hiding this comment.
TBH, I don't mind either way so I'll go with whatever you guys reckon is best. 👍
There was a problem hiding this comment.
Let's go with two constructors. We might only end up using the WithOptions one in the normal code, but it'll make the test code look a lot nicer.
|
/assign @roberthbailey |
|
@flaper87 - are you planning to finish this PR? |
|
@roberthbailey yep, I am. Sorry, just had a couple of travel weeks. |
|
@flaper87 - no worries, just wanted to make sure it should still be open while doing some PR backlog grooming. |
roberthbailey
added
the
needs-rebase
|
@flaper87 - can you rebase this so that we can merge it? |
|
@roberthbailey done! thanks for the heads up |
cmd/clusterctl/clusterdeployer/bootstrap/minikube/minikube_test.go
Outdated
Show resolved
Hide resolved
cmd/clusterctl/clusterdeployer/bootstrap/minikube/minikube_test.go
Outdated
Show resolved
Hide resolved
flaper87
force-pushed
the
master
branch
4 times, most recently
from
d16bce5
to
5f27cd8
Compare
roberthbailey
removed
the
needs-rebase
| @@ -27,15 +27,19 @@ import ( | |||
|
|
|||
| type Minikube struct { | |||
| kubeconfigpath string | |||
| vmDriver string | |||
| options []string | |||
|
@Lion-Wei @roberthbailey bah, thought I had run it. I did now, thanks for the review 😄 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
clusterctlexposes a couple of theminikubeCLI params, which is useful. Unfortunately, it still hides other params that may be essential. For example, it's currently not possible to set theinsecure-registryoption throughclusterctl, which is quite important for development.This PR proposes a new CLI param for
clusterctlthat acts as a proxy for theminikubeCLI params. This approach makes the interface/interaction betweenclusterctlandminikubeeasier to maintain.I realize there's a wish to make
clusterctlmore generic (not minikube dependant) and for that purpose, we could rename the--minikubeCLI param to something more generic--deployer-params.