-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster-API apiserver should be namespace-ed #509
Cluster-API apiserver should be namespace-ed #509
Conversation
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great job!
I've mentioned some points where default
is still being used, so make sure to check those.
pkg/deployer/clusterapiserver.go
Outdated
@@ -73,8 +73,13 @@ func getApiServerCerts() (*caCertParams, error) { | |||
return certParams, nil | |||
} | |||
|
|||
// GetApiServerYaml returns the clusterapi-apiserver manifest used for deployment | |||
// GetApiServerYaml returns the cluster-apiserver manifest for deployment in the default namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nitpick: I think it indeed is clusterapi-apiserver
. :)
81c3f14
to
1604261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left two more comments with suggestions for the potential improvements.
1604261
to
3084908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, great job!
/lgtm |
@xmudrii: changing LGTM is restricted to assignees, and only kubernetes-sigs/cluster-api repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about the diff in the generated file, otherwise lgtm.
} | ||
|
||
type NetworkRanges struct { | ||
CIDRBlocks []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having difficulty telling if there is an actual diff here outside of the generation script re-ordering the structs. If there is no actual diff, can you replace this with the existing upstream version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you didn't change api types, there shouldn't be any relevant changes in this file. Please remove from the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems fine, but I'm removing most of this code as part of #494 so don't get too dependent on it.
} | ||
|
||
type NetworkRanges struct { | ||
CIDRBlocks []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you didn't change api types, there shouldn't be any relevant changes in this file. Please remove from the PR.
* templatize Namespace in ClusterAPIAPIServerConfigTemplate * pass namespace to templating
3084908
to
8593eda
Compare
@detiber and @roberthbailey I have reverted the changes to the generated files. |
/lgtm |
/test |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashish-amarnath, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Identified a bug /gap in PR #481 has a gap where the cluster-api apiserver, for all clusters, would get created in the
default
namespace. This PR fixes that by passing thenamespace
to the manifest templating.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #252
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: