Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Rename Packet to Equinix Metal (in title only) #5774

Merged

Conversation

displague
Copy link
Member

@displague displague commented Dec 2, 2021

What this PR does / why we need it:

The Packet API (api.packet.net) continues to be supported and is fully integrated with the Equinix Metal experience, so CAPP continues to be a viable provider for existing Packet users and new Equinix Metal users.

This PR avoids confusion by retitling "Packet" to "Equinix Metal" in the documentation.

⚠️ Note The "Packet" tabs have been renamed to "Equinix Metal". If the space creates problems we may need to revise the tabs to "Equinix" or "EquinixMetal".

Binaries and variables should continue to use "Packet" names until a replacement to CAPP is made.

CAPP has already adopted some renaming and rearchitecting to adopt Equinix Metal branded tooling and settings. This work continues in kubernetes-sigs/cluster-api-provider-packet#289 (@detiber).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 2, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 2, 2021
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 723e0d6 into kubernetes-sigs:main Dec 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants