✨ Add IPAddress and IPAddressClaim CRs to Experimental API #6313

schrej · 2022-03-18T10:56:56Z

What this PR does / why we need it:
This implements the API contract described in the IPAM Proposal (#6000).
It adds two new Custom Resources to the experimental API: IPAddress and IPAddressClaim.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

k8s-ci-robot · 2022-03-18T10:56:58Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

schrej · 2022-06-10T18:13:19Z

/hold
This PR requires go 1.18 as it uses the net/netip package. Progress is tracked at the bottom of #5968.

cmd/clusterctl/api/v1alpha3/provider_type.go

exp/api/v1beta1/ipam_types.go

AectannArd

extend newtype descriptions for linking

exp/ipam/internal/webhooks/ipaddress.go

exp/ipam/api/v1alpha1/ipaddress_types.go

enxebre · 2022-07-06T18:19:18Z

thanks! lgtm overall other than this question #6313 (comment)

sbueringer · 2022-07-08T11:01:07Z

lgtm only pending #6313 (comment) from my side

sbueringer · 2022-07-08T12:10:10Z

/lgtm

Thank you very much for pushing this forward!

enxebre · 2022-07-08T12:43:18Z

/lgtm

sbueringer · 2022-07-08T13:02:42Z

/cherry-pick release-1.2

k8s-infra-cherrypick-robot · 2022-07-08T13:02:43Z

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fabriziopandini · 2022-07-08T18:33:09Z

/lgtm

sbueringer · 2022-07-11T07:09:45Z

/approve

k8s-ci-robot · 2022-07-11T07:10:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-infra-cherrypick-robot · 2022-07-11T07:26:28Z

@sbueringer: new pull request created: #6887

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2023-04-12T14:53:41Z

exp/ipam/api/v1alpha1/ipaddressclaim_types.go

+// IPAddressClaimSpec is the desired state of an IPAddressClaim.
+type IPAddressClaimSpec struct {
+	// PoolRef is a reference to the pool from which an IP address should be created.
+	PoolRef corev1.TypedLocalObjectReference `json:"poolRef"`


Was reviewing the enhancement and noticed this is using GroupKind to find obejcts, just wanted to note that this is discouraged now and that the TypedLocalObjectReference exists for legacy sake. Current API conventions recommend to create your own reference types (to avoid someone adding a new API field without you noticing) and to use GroupResource for unambiguity. I the API hasn't evolved past alpha yet, it might be worth looking at making that change before it is promoted to a more stable API

Seems to ~ fit in this discussion: #6539 ?

Yes I think it does, we should revive that conversation, I'll see if I can re-review that thread

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 18, 2022

k8s-ci-robot requested review from stmcginnis and vincepri March 18, 2022 10:57

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2022

schrej mentioned this pull request Mar 18, 2022

📖 add ipam integration proposal #6000

Merged

schrej force-pushed the feature/ipam branch from defd17c to 1f987ed Compare May 6, 2022 10:17

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022

schrej changed the title ~~[do-not-review] ✨ Add IPAddress and IPAddressClaim CRs to Experimental API~~ ✨ Add IPAddress and IPAddressClaim CRs to Experimental API May 6, 2022

schrej force-pushed the feature/ipam branch from 1f987ed to 5a2ee5f Compare May 23, 2022 17:08

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2022

schrej force-pushed the feature/ipam branch from 5a2ee5f to de200ab Compare June 10, 2022 18:11

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2022

schrej marked this pull request as ready for review June 10, 2022 18:11

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2022

k8s-ci-robot requested review from fabriziopandini and ykakarap June 10, 2022 18:11

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2022

schrej commented Jun 10, 2022

View reviewed changes

cmd/clusterctl/api/v1alpha3/provider_type.go Outdated Show resolved Hide resolved

schrej force-pushed the feature/ipam branch 2 times, most recently from 22ef513 to 948c005 Compare June 13, 2022 10:03

aartij17 mentioned this pull request Jun 13, 2022

IPAM support for CAPV kubernetes-sigs/cluster-api-provider-vsphere#1550

Closed

1 task

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2022

AectannArd reviewed Jun 24, 2022

View reviewed changes

exp/api/v1beta1/ipam_types.go Outdated Show resolved Hide resolved

exp/api/v1beta1/ipam_types.go Outdated Show resolved Hide resolved

AectannArd reviewed Jun 24, 2022

View reviewed changes

schrej force-pushed the feature/ipam branch from 948c005 to 379f44c Compare June 30, 2022 14:17

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2022

enxebre reviewed Jul 6, 2022

View reviewed changes

exp/ipam/internal/webhooks/ipaddress.go Show resolved Hide resolved

enxebre reviewed Jul 6, 2022

View reviewed changes

exp/ipam/internal/webhooks/ipaddress.go Outdated Show resolved Hide resolved

enxebre reviewed Jul 6, 2022

View reviewed changes

exp/ipam/api/v1alpha1/ipaddress_types.go Show resolved Hide resolved

schrej force-pushed the feature/ipam branch 2 times, most recently from 933bfcb to 4b3315e Compare July 7, 2022 09:17

add IPAddress and IPAddressClaim to exp api

7527a62

schrej force-pushed the feature/ipam branch from 4b3315e to 7527a62 Compare July 7, 2022 09:32

k8s-ci-robot assigned sbueringer Jul 8, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2022

k8s-ci-robot assigned enxebre Jul 8, 2022

k8s-ci-robot assigned fabriziopandini Jul 8, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022

k8s-ci-robot merged commit 05f10fd into kubernetes-sigs:main Jul 11, 2022

k8s-ci-robot added this to the v1.3 milestone Jul 11, 2022

k8s-infra-cherrypick-robot mentioned this pull request Jul 11, 2022

[release-1.2] ✨ Add IPAddress and IPAddressClaim CRs to Experimental API #6887

Merged

schrej deleted the feature/ipam branch July 11, 2022 09:27

schrej mentioned this pull request Jul 14, 2022

Add Support for CAPI IPAM Contract metal3-io/cluster-api-provider-metal3#671

Closed

jessehu mentioned this pull request Jul 30, 2022

Document stance on static IP addresses #1740

Closed

geetikabatra mentioned this pull request Nov 10, 2022

IPAM support for CAPO kubernetes-sigs/cluster-api-provider-openstack#1377

Closed

1 task

JoelSpeed reviewed Apr 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add IPAddress and IPAddressClaim CRs to Experimental API #6313

✨ Add IPAddress and IPAddressClaim CRs to Experimental API #6313

schrej commented Mar 18, 2022 •

edited

Loading

k8s-ci-robot commented Mar 18, 2022

schrej commented Jun 10, 2022

AectannArd left a comment

enxebre commented Jul 6, 2022

sbueringer commented Jul 8, 2022

sbueringer commented Jul 8, 2022

enxebre commented Jul 8, 2022

sbueringer commented Jul 8, 2022

k8s-infra-cherrypick-robot commented Jul 8, 2022

fabriziopandini commented Jul 8, 2022

sbueringer commented Jul 11, 2022

k8s-ci-robot commented Jul 11, 2022

k8s-infra-cherrypick-robot commented Jul 11, 2022

JoelSpeed Apr 12, 2023

sbueringer Apr 12, 2023

JoelSpeed Apr 12, 2023

✨ Add IPAddress and IPAddressClaim CRs to Experimental API #6313

✨ Add IPAddress and IPAddressClaim CRs to Experimental API #6313

Conversation

schrej commented Mar 18, 2022 • edited Loading

k8s-ci-robot commented Mar 18, 2022

schrej commented Jun 10, 2022

AectannArd left a comment

Choose a reason for hiding this comment

enxebre commented Jul 6, 2022

sbueringer commented Jul 8, 2022

sbueringer commented Jul 8, 2022

enxebre commented Jul 8, 2022

sbueringer commented Jul 8, 2022

k8s-infra-cherrypick-robot commented Jul 8, 2022

fabriziopandini commented Jul 8, 2022

sbueringer commented Jul 11, 2022

k8s-ci-robot commented Jul 11, 2022

k8s-infra-cherrypick-robot commented Jul 11, 2022

JoelSpeed Apr 12, 2023

Choose a reason for hiding this comment

sbueringer Apr 12, 2023

Choose a reason for hiding this comment

JoelSpeed Apr 12, 2023

Choose a reason for hiding this comment

schrej commented Mar 18, 2022 •

edited

Loading