Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 RuntimeSDK: Implement aggregateResponse for Runtime client #6581

Merged
merged 1 commit into from
Jun 8, 2022
Merged

🌱 RuntimeSDK: Implement aggregateResponse for Runtime client #6581

merged 1 commit into from
Jun 8, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Add aggregation logic to the runtime SDK client to correctly report results from CallAllExtensions.

Part of #6330

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 1, 2022
@killianmuldoon killianmuldoon changed the title [WIP] Implement aggregateResponse for Runtime client [WIP] 🌱 Implement aggregateResponse for Runtime client Jun 1, 2022
killianmuldoon
killianmuldoon commented Jun 1, 2022
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the message and status aggregation as we're only using Successful responses for aggregation. At this point I think the main thing left over is testing for CallAllExtensions.

@sbueringer sbueringer force-pushed the runtimeSDK/implement-client-aggregation branch from 8781492 to d520f8b Compare June 2, 2022 11:02
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2022
@sbueringer sbueringer force-pushed the runtimeSDK/implement-client-aggregation branch from d520f8b to 3237ef8 Compare June 2, 2022 12:41
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 2, 2022
@sbueringer sbueringer force-pushed the runtimeSDK/implement-client-aggregation branch from 3237ef8 to b580913 Compare June 2, 2022 12:43
@sbueringer sbueringer changed the title [WIP] 🌱 Implement aggregateResponse for Runtime client 🌱 RuntimeSDK: Implement aggregateResponse for Runtime client Jun 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2022
@sbueringer
Copy link
Member

I added more unit tests and did a bit of cleanup. PR is now ready for review

@sbueringer sbueringer mentioned this pull request Jun 2, 2022
Closed
30 tasks
ykakarap
ykakarap reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

internal/runtime/client/client_test.go Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
@sbueringer
Copy link
Member

@ykakarap Thx for the review, good findings. Should be fixed now.

ykakarap
ykakarap approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2022
@sbueringer sbueringer force-pushed the runtimeSDK/implement-client-aggregation branch from 93a57d0 to dce7674 Compare June 2, 2022 20:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2022
ykakarap
ykakarap approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@sbueringer
Copy link
Member

@fabriziopandini Thx for the review, should be all fixed now.

Q: Does it make a difference for you for "delta-reviewing" if I commit amend vs. push a separate commit for fixes?

@sbueringer sbueringer force-pushed the runtimeSDK/implement-client-aggregation branch from 1b5950d to 802f4c1 Compare June 7, 2022 05:47
ykakarap
ykakarap approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@sbueringer
Copy link
Member

/assign @killianmuldoon
for a final review

@ykakarap ykakarap mentioned this pull request Jun 8, 2022
Merged
@fabriziopandini
Copy link
Member

fabriziopandini commented Jun 8, 2022 •
edited
Loading

lgtm pending squash
great work!

@killianmuldoon @sbueringer
RuntimeSDK:implement aggregateResponse for Runtime client
6878983 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@sbueringer sbueringer force-pushed the runtimeSDK/implement-client-aggregation branch from 802f4c1 to 6878983 Compare June 8, 2022 12:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@sbueringer
Copy link
Member

Squashed

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 6878983 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@killianmuldoon
Copy link
Contributor Author

/lgtm

Thanks for taking this over @sbueringer 🙂

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: you cannot LGTM your own PR.

In response to this:

/lgtm

Thanks for taking this over @sbueringer 🙂

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/lgtm

Thanks for taking this over @sbueringer 🙂

Thx for implementing it :)

/cc @fabriziopandini for approval

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 8, 2022
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
ykakarap
ykakarap reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

Given lgtm's across the board + Fabrizio was only waiting for a squash

/approve
(even though I wrote half the PR)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4e26957 into kubernetes-sigs:main Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 8, 2022
@fabriziopandini
Copy link
Member

I'm late to the party
/lgtm
/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@ykakarap ykakarap ykakarap approved these changes

@vincepri vincepri Awaiting requested review from vincepri

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@killianmuldoon @sbueringer @fabriziopandini @k8s-ci-robot @ykakarap