Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump Go to 1.18.3 for Tiltfile, Container Images, Netlify #6616

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jun 9, 2022

What this PR does / why we need it:

Bumps Go to 1.18.3 in the following:

  1. Makefile
  2. hack/ensure-go.sh
  3. Tiltfile
  4. netlify.toml

Note: Bump for golangci-lint is intentionally as it is yet to roll out support for Go 1.18.

Signed-off-by: Nabarun Pal pal.nabarun95@gmail.com

Which issue(s) this PR fixes:

Part of #5968

/cc @sbueringer

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Jun 9, 2022
33 tasks
@sbueringer
Copy link
Member

Thx! A few nits + looks like we need make tiltfile-fix

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2022
…workflows

Also, updates the book.

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2022
@sbueringer
Copy link
Member

Thank you!

/lgtm

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit cf1e9b7 into kubernetes-sigs:main Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 9, 2022
@palnabarun palnabarun deleted the remaining-go-bumps branch June 9, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants