-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.2] 📖 add note ClusterClass compatibility info to validating webhooks section #6909
[release-1.2] 📖 add note ClusterClass compatibility info to validating webhooks section #6909
Conversation
@@ -35,4 +57,4 @@ type Cluster struct { | |||
A detailed guide on the purpose of each of these tags is [here](https://book.kubebuilder.io/reference/markers/webhook.html). | |||
|
|||
<!-- links --> | |||
[the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/release-1.1/internal/webhooks/cluster.go | |||
[the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/webhooks/cluster.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/webhooks/cluster.go | |
[the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/release-1.2/internal/webhooks/cluster.go |
cc @sbueringer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 1.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even drop the change?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we drop it here it will never end up in a published book.
I'm not sure how important it is to always point to the book to the corresponding version of the code. Seems like too much effort to maintain the correct mapping to be honest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missed that the current link points to release-1.1. Can someone open a follow-up PR (against main) to change that link to main as well?
See [the DockerMachineTemplate webhook] as a reference for a compatible implementation. | ||
|
||
[Server Side Apply]: https://kubernetes.io/docs/reference/using-api/server-side-apply/ | ||
[the DockerMachineTemplate webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/test/infrastructure/docker/api/v1beta1/dockermachinetemplate_webhook.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[the DockerMachineTemplate webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/test/infrastructure/docker/api/v1beta1/dockermachinetemplate_webhook.go | |
[the DockerMachineTemplate webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/release-1.2/test/infrastructure/docker/api/v1beta1/dockermachinetemplate_webhook.go |
Maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I think that's right
/lgtm |
Let's keep this on main for now, We can eventually iterate to make book maintenance simpler |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #6875
/assign sbueringer