✨ ClusterClass patches: Allow matching all MachineDeploymentClasses #6930

valaparthvi · 2022-07-15T08:20:16Z

What this PR does / why we need it:

This PR adds a new feature to allow matching all "*" MachineDeploymentClasses.

Match all if MachineDeploymentClass.Names is a "*".

matchResources:
  machineDeploymentClass:
    names : [*]

Match some if explicitly mentioned.

matchResources:
  machineDeploymentClass:
    names: [something, something, something]

Match some if glob matched.

matchResources:
  machineDeploymentClass:
    names: [something-*]

Match none if no machineDeploymentClass is set (should produce a webhook failure)

matchResources:
  machineDeploymentClass: {}

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5648

k8s-ci-robot · 2022-07-15T08:20:25Z

Hi @valaparthvi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

killianmuldoon

Overall I think this might be useful, but is there a cleaner way to do it in the API? Just not a fan of using regex-lookalike syntax if we're not supporting any real pattern matching. Would it be reasonable to have the empty selector act as a match all? i.e. https://github.com/kubernetes/apimachinery/blob/afc5e00a762a432aa7d988d711dab6dcf3427585/pkg/apis/meta/v1/helpers.go#L38

No selector matches nothing
Empty selector matches everything

sbueringer · 2022-07-15T13:25:20Z

I think using * which is already established in Kubernetes for ClusterRoles/Roles is better than using something like empty or no selector. It's way more explicit that way.

How would an empty selector look like for the names slice that we have today?

        matchResources:
          machineDeploymentClass:
            names:
            - default-worker

killianmuldoon · 2022-07-15T13:35:31Z

How would an empty selector look like for the names slice that we have today?

        matchResources:
          machineDeploymentClass: {}

That's my understanding of how it normally works in Kubernetes with the label selector. It would require enabling it (and maybe even setting it) in the webhook.

I think it's more consistent to stick to how selectors work in Kubernetes rather than RBAC, despite it being implicit. Definitely not a blocker for implementing it as is with the '*' notation, but it does depart from convention IMO.

killianmuldoon · 2022-07-15T13:35:46Z

/ok-to-test

valaparthvi · 2022-07-18T06:20:26Z

@killianmuldoon @sbueringer So, what have you decided? Are we going with K8s way or RBAC way?
The K8s way does not seem very intuitive to me, or if that is the way it happens generally, it might be intuitive for others. RBAC on the other hand is quite simple.

sbueringer · 2022-07-18T11:48:17Z

Thought about it a bit more. I think Killian is right. It makes sense to stay consistent with Kubernetes selectors.

This would give us the following semantics:

Match specific MD classes

        matchResources:
          controlPlane: true
          machineDeploymentClass:
            names:
            - default-worker

Match all MD classes

        matchResources:
          controlPlane: true
          machineDeploymentClass: {}

Match none MD classes

        matchResources:
          controlPlane: true

We should not set the selector in the defaulting webhook. The idea in the ClusterClass API is that folks should explicitly decide to select InfraCluster, CP, MD classes, ... . If we would default to {} the selector would match all MD classes per default and folks have to set some not-matching MD class names to still be able to not match MD classes.

(I think it comes down to in Kubernetes it's default: "match all", and in our cases the default is "match none")

One nice thing about {} is that it works on the machineDeploymentClass level. While * would be part of names. It seems better to have that match all only once on the machineDeploymentClass vs needing it in names and every other filter critera we might add in the future.

Independent of that, I absolutely don't like what they did there it is way to implicit for my taste.

internal/controllers/topology/cluster/patches/inline/json_patch_generator.go

internal/controllers/topology/cluster/patches/inline/json_patch_generator_test.go

valaparthvi · 2022-07-27T13:27:51Z

@sbueringer I can't seem to run unit tests for util/patch/patch_test.go locally, neither from my branch, and nor from main branch. I see they're failing on CI as well. Do I need to run some setup? I have a kind cluster running.

Here is the output from when I run the tests.

/usr/local/go/bin/go tool test2json -t /tmp/GoLand/___TestPatchHelper_in_sigs_k8s_io_cluster_api_util_patch.test -test.v -test.paniconexit0 -test.run ^\QTestPatchHelper\E$
E0727 18:57:10.811564  125075 logr.go:265] controller-runtime/test-env "msg"="unable to start the controlplane" "error"="fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"  "tries"=0
E0727 18:57:10.812226  125075 logr.go:265] controller-runtime/test-env "msg"="unable to start the controlplane" "error"="fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"  "tries"=1
E0727 18:57:10.812763  125075 logr.go:265] controller-runtime/test-env "msg"="unable to start the controlplane" "error"="fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"  "tries"=2
E0727 18:57:10.813390  125075 logr.go:265] controller-runtime/test-env "msg"="unable to start the controlplane" "error"="fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"  "tries"=3
E0727 18:57:10.813975  125075 logr.go:265] controller-runtime/test-env "msg"="unable to start the controlplane" "error"="fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory"  "tries"=4
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x14f55af]

goroutine 1 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/testing/controlplane.(*APIServer).Stop(0x14)
	/home/pvala/go/src/github.com/kubernetes-sigs/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/internal/testing/controlplane/apiserver.go:424 +0x8f
sigs.k8s.io/controller-runtime/pkg/internal/testing/controlplane.(*ControlPlane).Stop(0xc0005af180)
	/home/pvala/go/src/github.com/kubernetes-sigs/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/internal/testing/controlplane/plane.go:97 +0x3d
sigs.k8s.io/controller-runtime/pkg/envtest.(*Environment).Stop(0xc0005af180)
	/home/pvala/go/src/github.com/kubernetes-sigs/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/envtest/server.go:194 +0x114
sigs.k8s.io/cluster-api/internal/test/envtest.newEnvironment({0x0, 0x0, 0xc000598600})
	/home/pvala/go/src/github.com/kubernetes-sigs/cluster-api/internal/test/envtest/environment.go:209 +0x22e5
sigs.k8s.io/cluster-api/internal/test/envtest.Run({0x1de86b0, 0xc0004ccf40}, {0xc000184000, {0x0, 0x0, 0x0}, 0x0, 0x0, 0x1c2d2a8, {0x0, ...}})
	/home/pvala/go/src/github.com/kubernetes-sigs/cluster-api/internal/test/envtest/environment.go:112 +0x66
sigs.k8s.io/cluster-api/util/patch.TestMain(0xc0000001a0)
	/home/pvala/go/src/github.com/kubernetes-sigs/cluster-api/util/patch/suite_test.go:39 +0x66
main.main()
	_testmain.go:51 +0x165

killianmuldoon · 2022-07-27T13:29:41Z

The issue seems to be your env test setup - do all the tests run when you run make test ? You may need to set the KUBEBUILDER_ASSETS env variable

valaparthvi · 2022-07-27T14:30:48Z

The issue seems to be your env test setup - do all the tests run when you run make test ?
You may need to set the KUBEBUILDER_ASSETS env variable

I was actually running the tests directly from my GoLand editor, and I didn't realize I had to set the envvar, but it seems like make test passed on both the branches.

I also noticed pull-cluster-api-verify-main is failing because I failed to update config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml. Is there a Make target that I should run to update this yaml or will this be a manual change?

pull-cluster-api-verify-main failure

 API rule violation: list_type_missing,sigs.k8s.io/cluster-api/exp/runtime/hooks/api/v1alpha1,GeneratePatchesResponseItem,Patch
API rule violation: list_type_missing,sigs.k8s.io/cluster-api/exp/runtime/hooks/api/v1alpha1,ValidateTopologyRequest,Items
API rule violation: list_type_missing,sigs.k8s.io/cluster-api/exp/runtime/hooks/api/v1alpha1,ValidateTopologyRequest,Variables
API rule violation: list_type_missing,sigs.k8s.io/cluster-api/exp/runtime/hooks/api/v1alpha1,ValidateTopologyRequestItem,Variables
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api'
diff --git a/api/v1beta1/zz_generated.openapi.go b/api/v1beta1/zz_generated.openapi.go
index 01c418b08..9868b1071 100644
--- a/api/v1beta1/zz_generated.openapi.go
+++ b/api/v1beta1/zz_generated.openapi.go
@@ -2715,7 +2715,7 @@ func schema_sigsk8sio_cluster_api_api_v1beta1_PatchSelectorMatch(ref common.Refe
 					},
 					"machineDeploymentClass": {
 						SchemaProps: spec.SchemaProps{
-							Description: "MachineDeploymentClass selects templates referenced in specific MachineDeploymentClasses in .spec.workers.machineDeployments.",
+							Description: "MachineDeploymentClass selects templates referenced in specific MachineDeploymentClasses in .spec.workers.machineDeployments. Note: If set to an empty object it will match all MachineDeploymentClasses.",
 							Ref:         ref("sigs.k8s.io/cluster-api/api/v1beta1.PatchSelectorMatchMachineDeploymentClass"),
 						},
 					},
diff --git a/config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml b/config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml
index d9f504c8a..b96e494dc 100644
--- a/config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml
+++ b/config/crd/bases/cluster.x-k8s.io_clusterclasses.yaml
@@ -770,9 +770,10 @@ spec:
                                       referenced in .spec.infrastructure.
+             
                         set to an empty object it will match all MachineDeploymentClasses.'
                                     properties:
                                       names:
                                         description: Names selects templates by class
generated files are out of date, run make generate
make: *** [Makefile:482: verify-gen] Error 1
+ EXIT_VALUE=2

killianmuldoon · 2022-07-27T14:42:56Z

The CR definitions are created using make generate and its sub-targets. make generate takes a long time to run, so you might want to just run make generate-manifests and maybe make generate-openapi

Note - it's not a good idea to run make verify-gen locally as it runs the full make generate if you're in doubt, you can just run the full job (takes about 20 minutes for me locally, but heavily depends on setup and OS.

ykakarap

LGTM pending squash.

api/v1beta1/clusterclass_types.go

valaparthvi · 2022-07-29T07:05:12Z

The CR definitions are created using make generate and its sub-targets. make generate takes a long time to run, so you might want to just run make generate-manifests and maybe make generate-openapi

Note - it's not a good idea to run make verify-gen locally as it runs the full make generate if you're in doubt, you can just run the full job (takes about 20 minutes for me locally, but heavily depends on setup and OS.

Thank you for this! And I think it's make generate-go-openapi, and not make generate-openapi, I couldn't find that target.

valaparthvi · 2022-07-29T08:14:07Z

I am not sure how to fix pull-cluster-api-verify-main job. I've run a different make targets locally, but I seem to have reached nowhere. I've run make generate, which modifies a few files, none of which contains the file in question(api/v1beta1/zz_generated.openapi.go). I've also run make generate-go-openapi which seems to be doing nothing.

O/P from `make generate`

git status
On branch 5648-allow-matching-all-mdc
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	renamed:    api/v1alpha3/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/api/v1alpha3/zz_generated.conversion.go
	renamed:    api/v1alpha4/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/api/v1alpha4/zz_generated.conversion.go
	renamed:    bootstrap/kubeadm/api/v1alpha3/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/bootstrap/kubeadm/api/v1alpha3/zz_generated.conversion.go
	renamed:    bootstrap/kubeadm/api/v1alpha4/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/bootstrap/kubeadm/api/v1alpha4/zz_generated.conversion.go
	renamed:    bootstrap/kubeadm/types/upstreamv1beta1/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/bootstrap/kubeadm/types/upstreamv1beta1/zz_generated.conversion.go
	renamed:    bootstrap/kubeadm/types/upstreamv1beta2/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/bootstrap/kubeadm/types/upstreamv1beta2/zz_generated.conversion.go
	renamed:    bootstrap/kubeadm/types/upstreamv1beta3/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/bootstrap/kubeadm/types/upstreamv1beta3/zz_generated.conversion.go
	renamed:    controlplane/kubeadm/api/v1alpha3/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/controlplane/kubeadm/api/v1alpha3/zz_generated.conversion.go
	renamed:    controlplane/kubeadm/api/v1alpha4/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/controlplane/kubeadm/api/v1alpha4/zz_generated.conversion.go
	renamed:    exp/addons/api/v1alpha3/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/exp/addons/api/v1alpha3/zz_generated.conversion.go
	renamed:    exp/addons/api/v1alpha4/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/exp/addons/api/v1alpha4/zz_generated.conversion.go
	renamed:    exp/api/v1alpha3/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/exp/api/v1alpha3/zz_generated.conversion.go
	renamed:    exp/api/v1alpha4/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/exp/api/v1alpha4/zz_generated.conversion.go
	renamed:    internal/runtime/test/v1alpha1/zz_generated.conversion.go -> github.com/kubernetes-sigs/cluster-api/internal/runtime/test/v1alpha1/zz_generated.conversion.go
	new file:   test/infrastructure/docker/github.com/kubernetes-sigs/cluster-api/test/infrastructure/docker/api/v1alpha3/zz_generated.conversion.go
	new file:   test/infrastructure/docker/github.com/kubernetes-sigs/cluster-api/test/infrastructure/docker/api/v1alpha4/zz_generated.conversion.go
	new file:   test/infrastructure/docker/github.com/kubernetes-sigs/cluster-api/test/infrastructure/docker/exp/api/v1alpha3/zz_generated.conversion.go
	new file:   test/infrastructure/docker/github.com/kubernetes-sigs/cluster-api/test/infrastructure/docker/exp/api/v1alpha4/zz_generated.conversion.go

Can someone help me fix this? @killianmuldoon

ykakarap

Can you share the output of make generate-go-openapi?

I was able to run make generate-go-openapi on this PR and it generated the required change to fix the issue in pull-cluster-api-verify-main job. So, I don't the issue is with any of the changes that are part of this PR.

It is weird that when you run make generate the generated files are getting renamed 🤔 . Is your project clones outside the GOPATH (although that should not cause any problems as there is logic in the make file to take care of it: https://github.com/valaparthvi/cluster-api/blob/e0bdc2455bef5e537888f10c45149f0df6cede72/Makefile#L65-L71)?

internal/controllers/topology/cluster/patches/inline/json_patch_generator_test.go

killianmuldoon · 2022-08-03T13:25:10Z

@valaparthvi When I run make generate-go-openapi locally I get changes in api/v1beta1/zz_generated.openapi.go. Could you share some information about the environment in which you're running the command? e.g. cluster api most recent commit (before your changes), os type and kernel version, and the directory in which you're running the make command.

i.e. the output of:

git log --oneline | head -n 5
go env | grep 'GOOS\|GOARCH\|GOVERSION\|GOPATH'
The output of pwd in the directory you're running the make commands.

Note the above will likely only work for Mac / Linux. If you're in a Windows environment you may need to find a different path to providing that information.

fabriziopandini · 2022-12-29T16:41:25Z

it seems there is a test failure to be fixed as weel 😅

sbueringer · 2023-01-11T08:34:38Z

Alright, will take a look ASAP

internal/webhooks/patch_validation.go

sbueringer · 2023-01-12T06:46:31Z

/retest

sbueringer · 2023-01-12T16:00:58Z

Thank you very much!!

/lgtm

Can you please squash the commits?

k8s-ci-robot · 2023-01-12T16:01:05Z

LGTM label has been added.

Git tree hash: 524d48e521fe764834345c1fcba637182a4ff70b

Signed-off-by: Parthvi Vala <pvala@redhat.com> Use glob match Update OpenAPI docs Update internal/controllers/topology/cluster/patches/inline/json_patch_generator.go Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com> Add validation for selectors Signed-off-by: Parthvi Vala <pvala@redhat.com> Using prefix and suffix match instead of regex Signed-off-by: Parthvi Vala <pvala@redhat.com> Fix test failures Signed-off-by: Parthvi Vala <pvala@redhat.com> Add pattern matching to validateSelectors Signed-off-by: Parthvi Vala <pvala@redhat.com> Update clusterclass-quick-start.yaml to use pattern match example Signed-off-by: Parthvi Vala <pvala@redhat.com> Attempt at fixing pull-cluster-api-e2e-informing-main Signed-off-by: Parthvi Vala <pvala@redhat.com>

sbueringer · 2023-01-12T17:26:41Z

Thx!

/lgtm

/assign @fabriziopandini

k8s-ci-robot · 2023-01-12T17:26:46Z

LGTM label has been added.

Git tree hash: b7af886b47804ecdf380e959a72dc707f236f5cb

fabriziopandini · 2023-01-16T11:28:06Z

kudos to @valaparthvi for bearing with us for so long! (and sorry for the limited bandwidth in reviewing this work)
that's a nice addition!
/lgtm
/approve

k8s-ci-robot · 2023-01-16T11:28:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2023-01-16T12:03:46Z

/hold cancel

I absolutely agree. Thank you very much @valaparthvi for the patience and tenacity!! 🎉

valaparthvi · 2023-01-16T13:24:28Z

Thank you to you both as well @sbueringer @fabriziopandini and to all those who reviewed this PR. I know I was very slow at times but I appreciate everyone's patience with me :)

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2022

k8s-ci-robot requested review from JoelSpeed and ykakarap July 15, 2022 08:20

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 15, 2022

valaparthvi changed the title ~~✨ ClusterClass patches: Allow matching all MachineDeploymentClasses~~ WIP: ✨ ClusterClass patches: Allow matching all MachineDeploymentClasses Jul 15, 2022

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022

killianmuldoon reviewed Jul 15, 2022

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2022

sbueringer reviewed Jul 19, 2022

View reviewed changes

internal/controllers/topology/cluster/patches/inline/json_patch_generator.go Outdated Show resolved Hide resolved

internal/controllers/topology/cluster/patches/inline/json_patch_generator_test.go Outdated Show resolved Hide resolved

ykakarap reviewed Jul 28, 2022

View reviewed changes

api/v1beta1/clusterclass_types.go Outdated Show resolved Hide resolved

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022

valaparthvi changed the title ~~WIP: ✨ ClusterClass patches: Allow matching all MachineDeploymentClasses~~ ✨ ClusterClass patches: Allow matching all MachineDeploymentClasses Jul 29, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2022

ykakarap reviewed Aug 2, 2022

View reviewed changes

internal/controllers/topology/cluster/patches/inline/json_patch_generator_test.go Outdated Show resolved Hide resolved

sbueringer reviewed Jan 11, 2023

View reviewed changes

internal/webhooks/patch_validation.go Outdated Show resolved Hide resolved

internal/webhooks/patch_validation.go Outdated Show resolved Hide resolved

internal/webhooks/patch_validation.go Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023

valaparthvi force-pushed the 5648-allow-matching-all-mdc branch from 9842370 to 33e9a5b Compare January 12, 2023 05:50

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023

valaparthvi force-pushed the 5648-allow-matching-all-mdc branch from 33e9a5b to ca5ff4b Compare January 12, 2023 05:59

k8s-ci-robot assigned sbueringer Jan 12, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023

valaparthvi force-pushed the 5648-allow-matching-all-mdc branch from cd706a6 to df9283c Compare January 12, 2023 16:08

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023

k8s-ci-robot requested review from killianmuldoon, sbueringer and ykakarap January 12, 2023 16:08

k8s-ci-robot assigned fabriziopandini Jan 12, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023

k8s-ci-robot merged commit 0119de7 into kubernetes-sigs:main Jan 16, 2023

k8s-ci-robot added this to the v1.4 milestone Jan 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ ClusterClass patches: Allow matching all MachineDeploymentClasses #6930

✨ ClusterClass patches: Allow matching all MachineDeploymentClasses #6930

valaparthvi commented Jul 15, 2022 •

edited

Loading

k8s-ci-robot commented Jul 15, 2022

killianmuldoon left a comment •

edited

Loading

sbueringer commented Jul 15, 2022 •

edited

Loading

killianmuldoon commented Jul 15, 2022

killianmuldoon commented Jul 15, 2022

valaparthvi commented Jul 18, 2022

sbueringer commented Jul 18, 2022 •

edited

Loading

valaparthvi commented Jul 27, 2022 •

edited

Loading

killianmuldoon commented Jul 27, 2022 •

edited

Loading

valaparthvi commented Jul 27, 2022 •

edited

Loading

killianmuldoon commented Jul 27, 2022

ykakarap left a comment

valaparthvi commented Jul 29, 2022

valaparthvi commented Jul 29, 2022 •

edited

Loading

ykakarap left a comment

killianmuldoon commented Aug 3, 2022

fabriziopandini commented Dec 29, 2022

sbueringer commented Jan 11, 2023

sbueringer commented Jan 12, 2023

sbueringer commented Jan 12, 2023

k8s-ci-robot commented Jan 12, 2023

sbueringer commented Jan 12, 2023

k8s-ci-robot commented Jan 12, 2023

fabriziopandini commented Jan 16, 2023

k8s-ci-robot commented Jan 16, 2023

sbueringer commented Jan 16, 2023

valaparthvi commented Jan 16, 2023

✨ ClusterClass patches: Allow matching all MachineDeploymentClasses #6930

✨ ClusterClass patches: Allow matching all MachineDeploymentClasses #6930

Conversation

valaparthvi commented Jul 15, 2022 • edited Loading

k8s-ci-robot commented Jul 15, 2022

killianmuldoon left a comment • edited Loading

Choose a reason for hiding this comment

sbueringer commented Jul 15, 2022 • edited Loading

killianmuldoon commented Jul 15, 2022

killianmuldoon commented Jul 15, 2022

valaparthvi commented Jul 18, 2022

sbueringer commented Jul 18, 2022 • edited Loading

valaparthvi commented Jul 27, 2022 • edited Loading

killianmuldoon commented Jul 27, 2022 • edited Loading

valaparthvi commented Jul 27, 2022 • edited Loading

killianmuldoon commented Jul 27, 2022

ykakarap left a comment

Choose a reason for hiding this comment

valaparthvi commented Jul 29, 2022

valaparthvi commented Jul 29, 2022 • edited Loading

ykakarap left a comment

Choose a reason for hiding this comment

killianmuldoon commented Aug 3, 2022

fabriziopandini commented Dec 29, 2022

sbueringer commented Jan 11, 2023

sbueringer commented Jan 12, 2023

sbueringer commented Jan 12, 2023

k8s-ci-robot commented Jan 12, 2023

sbueringer commented Jan 12, 2023

k8s-ci-robot commented Jan 12, 2023

fabriziopandini commented Jan 16, 2023

k8s-ci-robot commented Jan 16, 2023

sbueringer commented Jan 16, 2023

valaparthvi commented Jan 16, 2023

valaparthvi commented Jul 15, 2022 •

edited

Loading

killianmuldoon left a comment •

edited

Loading

sbueringer commented Jul 15, 2022 •

edited

Loading

sbueringer commented Jul 18, 2022 •

edited

Loading

valaparthvi commented Jul 27, 2022 •

edited

Loading

killianmuldoon commented Jul 27, 2022 •

edited

Loading

valaparthvi commented Jul 27, 2022 •

edited

Loading

valaparthvi commented Jul 29, 2022 •

edited

Loading