-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update docs/Makefile #7033
✨ Update docs/Makefile #7033
Conversation
@oscr: This issue is currently awaiting triage. If CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-verify-main |
5cc52ee
to
7ac2411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be careful with the differences between the new and old images - some of them appear to be incorrectly formatted so we might need to update the plantuml files so that the resulting images are closer to the originals.
Would it be possible to do this incrementally? I understand there might be a large amount of work to update the images so the newer version of plantuml produces something close to the original versions. If it's possible we could create an umbrella task to update these images one-by-one (or batch by batch)
What would you say about removing the updates to proposals and change the "make diagrams" just builds the CAPI book? The proposals don't need to be updated so we can just let them be. Then in a separate pr we can either update the diagrams target or add a separate target for proposals diagrams together with fixes for them. Sounds ok @killianmuldoon? |
Could we maybe add two targets - We would need a solution to the broken proposal images sooner rather than later though as it would impact anyone trying to create new images for a proposal. |
I must have missed the updates on #7017 - it looks like there's a few issues there as well. Have you made any progress on figuring out why the layering / opacity is changing? I think that's the fundamental problem, everybody else seemed happy with the colors on that PR 😆 |
ff26b46
to
cc642cd
Compare
Thanks for making the updates! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I noticed that the docs/Makefile diagrams target uses an old PlantUML container from
k8s.gcr.io
. I took some inspiration from OpenStack provider and updated the Makefile in the following way.Finally I also regenerated the proposal diagrams since they where generated with an older version of PlantUML.
Makefile help output: