馃尡 test/e2e: Drop support for Kubernetes < v1.24.0 in the RuntimeSDK upgrade test #7172
Conversation
k8s-ci-robot
added
cncf-cla: yes
upgrade test Signed-off-by: Stefan B眉ringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-e2e-test-drop-cgroupfs
branch
from
cb654dd
to
318dc0b
Compare
| // Random generate later on again when Yuvaraj's PR has split up the cluster lifecycle. | ||
| //Name: fmt.Sprintf("%s-%s", specName, util.RandomString(6)), | ||
| // Note: We have to use a constant name here as we have to be able to reference it in the ClusterClass | ||
| // when configuring external patches. |
There was a problem hiding this comment.
Just saw the todo and dropped it. I don't think it's worth the effort to generate the ExtensionConfig name randomly
There was a problem hiding this comment.
Hmm - this can still be annoying when running manually as I regularly need to manually delete the ExtensionConfig if the test fails unexpectedly.
Could we delete the ExtensionConfig if it exists inside this test? It's mainly a problem because it's a global object.
There was a problem hiding this comment.
I'm happy to take this as a follow-up
sbueringer
changed the title
|
/test pull-cluster-api-e2e-full-main |
|
/assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
We have to support older Kubernetes versions in the regular upgrade test. I don't think we have to support it in the RuntimeSDK upgrade test though. The goal of this test is to specifically test RuntimeSDK, there is no need to run in on older Kubernetes versions (and in fact nobody does it).
Goal of dropping the support is to decrease complexitiy and increase maintainability of this test.
Note: This was unblocked by the recent bump, as we now test v1.24=>v1.25.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #6661