New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 🌱 Use manager and builder pkgs of controller-runtime explicitly. #7175

Closed

johannesfrey wants to merge 1 commit into kubernetes-sigs:main from mercedes-benz:do-not-use-controller-runtime-alias

Commits on Sep 6, 2022

Use manager and builder pkgs of controller-runtime explicitly.

Otherwise, controller-runtime will implicitly set the `kubeconfig` flag
to the global command line FlagSet when using the alias types defined in
alias.go. See:
https://github.com/kubernetes-sigs/controller-runtime/blob/15b6689c55745514d6bade4c55efb3333c0da4d9/alias.go#L80

The usage of the alias types potentially collides with user code that
imports the api packages of Cluster API.

Signed-off-by: Johannes Frey <johannes.frey@mercedes-benz.com>

Johannes Frey committed Sep 6, 2022