Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add support for raw template URL in clusterctl generate yaml #7371

Merged
merged 1 commit into from
Jan 2, 2023
Merged

✨ Add support for raw template URL in clusterctl generate yaml #7371

merged 1 commit into from
Jan 2, 2023

Conversation

aniruddha2000
Copy link
Contributor

Signed-off-by: Aniruddha Basak codewithaniruddha@gmail.com

What this PR does / why we need it:

This PR let's people use raw URL for clusterctl generate yaml command

Fixes #6535

/cc @ykakarap @sbueringer

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2022
@aniruddha2000 aniruddha2000 requested review from fabriziopandini and removed request for sbueringer and ykakarap October 10, 2022 15:46
@sbueringer sbueringer mentioned this pull request Nov 1, 2022
Merged
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 20, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aniruddha2000 / name: Aniruddha Basak (8562af8)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2022
@aniruddha2000 aniruddha2000 force-pushed the aniruddha/add-raw-template-url branch 3 times, most recently from 7d2cb24 to d0839ac Compare November 20, 2022 13:39
@aniruddha2000
Copy link
Contributor Author

Any idea why there is missing CLA? I have signed all the docs as well :)

@aniruddha2000 aniruddha2000 force-pushed the aniruddha/add-raw-template-url branch 2 times, most recently from d717a59 to 6416dad Compare November 20, 2022 14:03
@sbueringer
Copy link
Member

Any idea why there is missing CLA? I have signed all the docs as well :)

Not sure. This looks a bit strange "Aniruddha Basak authored and aniruddha2000 committed 15 hours ago"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 21, 2022
@aniruddha2000
Copy link
Contributor Author

@sbueringer ah thanks! Now I get it as it's my new machine I messed the author for the first time
I fixed it with - git commit --amend --author="Aniruddha Basak <codewithaniruddha@gmail.com>" --no-edit

@aniruddha2000 aniruddha2000 requested review from ykakarap and sbueringer and removed request for fabriziopandini and ykakarap November 22, 2022 03:20
@aniruddha2000
Add getRawUrlFileContent method to handle raw url & Unit Test
48a837d 
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
ykakarap
ykakarap approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great work! Thank you.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@sbueringer
Copy link
Member

/assign @fabriziopandini

@fabriziopandini
Copy link
Member

/lgtm
/approve

@aniruddha2000, it will be great if we can make a follow-up PR documenting this new feature in https://cluster-api.sigs.k8s.io/clusterctl/commands/generate-cluster.html

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9d1637b into kubernetes-sigs:main Jan 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 2, 2023
This was referenced Jan 11, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@ykakarap ykakarap ykakarap approved these changes

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Add support for raw template URL in clusterctl generate yaml
5 participants
@aniruddha2000 @sbueringer @fabriziopandini @k8s-ci-robot @ykakarap