-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for raw template URL in clusterctl generate yaml #7371
✨ Add support for raw template URL in clusterctl generate yaml #7371
Conversation
75d2713
to
a5ad52e
Compare
a5ad52e
to
7562a23
Compare
7562a23
to
34eead1
Compare
34eead1
to
e76e20e
Compare
|
7d2cb24
to
d0839ac
Compare
Any idea why there is missing CLA? I have signed all the docs as well :) |
d717a59
to
6416dad
Compare
Not sure. This looks a bit strange "Aniruddha Basak authored and aniruddha2000 committed 15 hours ago" |
6416dad
to
8562af8
Compare
@sbueringer ah thanks! Now I get it as it's my new machine I messed the author for the first time |
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
8562af8
to
48a837d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Great work! Thank you.
/assign @fabriziopandini |
/lgtm @aniruddha2000, it will be great if we can make a follow-up PR documenting this new feature in https://cluster-api.sigs.k8s.io/clusterctl/commands/generate-cluster.html |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Aniruddha Basak codewithaniruddha@gmail.com
What this PR does / why we need it:
This PR let's people use raw URL for
clusterctl generate yaml
commandFixes #6535
/cc @ykakarap @sbueringer