Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement Reconcile mode for ClusterResourceSet #7497

Merged
merged 22 commits into from
Feb 19, 2023
Merged

✨ Implement Reconcile mode for ClusterResourceSet #7497

merged 22 commits into from
Feb 19, 2023

Commits on Nov 28, 2022

  1. Implement Reconcile mode for ClusterResourceSet

    @g-gaston
    g-gaston committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a6ef8dc View commit details
    Browse the repository at this point in the history

  2. Update ApplyClusterResourceSet doc comment with Reconcile strategy

    @g-gaston
    g-gaston committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4e02c8f View commit details
    Browse the repository at this point in the history

  3. Added strategy update instructions to docs

    @g-gaston
    g-gaston committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5f62bc7 View commit details
    Browse the repository at this point in the history

  4. Fix typo 

    Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
    @g-gaston @sbueringer
    g-gaston and sbueringer committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b70f649 View commit details
    Browse the repository at this point in the history

  5. Use ResourceCreateOrUpdate to dry naked predicates

    @g-gaston
    g-gaston committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0c5ee40 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Update exp/addons/internal/controllers/clusterresourceset_controller.go 

    Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
    @g-gaston @sbueringer
    g-gaston and sbueringer committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    9586cb5 View commit details
    Browse the repository at this point in the history

  2. Addressed review comment: minor cleanup

    @g-gaston
    g-gaston committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    b0c7337 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Set resource version before patch for reconcile mode

    @g-gaston
    g-gaston committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    1826148 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Address review coments: rename GetResourceBinding

    @g-gaston
    g-gaston committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    fe1613e View commit details
    Browse the repository at this point in the history

  2. Simplify IsApplied 

    Co-authored-by: Fabrizio Pandini <fabrizio.pandini@gmail.com>
    @g-gaston @fabriziopandini
    g-gaston and fabriziopandini committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    34725cd View commit details
    Browse the repository at this point in the history

  3. Address review coments: use switch and drop IsStrategy

    @g-gaston
    g-gaston committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    86193c9 View commit details
    Browse the repository at this point in the history

  4. Improve client error wraps 

    Co-authored-by: Fabrizio Pandini <fabrizio.pandini@gmail.com>
    @g-gaston @fabriziopandini
    g-gaston and fabriziopandini committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    3a4bb5f View commit details
    Browse the repository at this point in the history

  5. Add unit test to check for apply once logic re-entry

    @g-gaston
    g-gaston committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    c033f00 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Implement top loevel apply methoid in resource scopes

    @g-gaston
    g-gaston committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6c656f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Improve test case names 

    Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
    @g-gaston @sbueringer
    g-gaston and sbueringer committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    199fcce View commit details
    Browse the repository at this point in the history

  2. Check scope error before setting binding to improve legibility

    @g-gaston
    g-gaston committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a69ab2e View commit details
    Browse the repository at this point in the history

  3. Fix typo 

    Co-authored-by: Fabrizio Pandini <fabrizio.pandini@gmail.com>
    @g-gaston @fabriziopandini
    g-gaston and fabriziopandini committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d7d1ffa View commit details
    Browse the repository at this point in the history

  4. Improve errors in crs normalize data and scope

    @g-gaston
    g-gaston committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    2891a9c View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Add tests to cover ApplyOnce reentry and idempotency

    @g-gaston
    g-gaston committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    9f84d7e View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Fix typos 

    Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
    @g-gaston @sbueringer
    g-gaston and sbueringer committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    aed9907 View commit details
    Browse the repository at this point in the history

  2. Fix exp/addons/internal/controllers/clusterresourceset_controller_tes… 

    …t.go typo

Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
    @g-gaston @sbueringer
    g-gaston and sbueringer committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    d4635bb View commit details
    Browse the repository at this point in the history

  3. Improve generate namespace function

    @g-gaston
    g-gaston committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    c32cf26 View commit details
    Browse the repository at this point in the history