Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add release tasks doc and corresponding issue template #7499

Merged
merged 1 commit into from
Nov 18, 2022
Merged

📖 Add release tasks doc and corresponding issue template #7499

merged 1 commit into from
Nov 18, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 4, 2022 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Let's ignore the markdown checker. The links won't actually be broken after merge.

Examples:

Part of #7389

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2022
@sbueringer sbueringer mentioned this pull request Nov 4, 2022
Closed
6 tasks
@sbueringer sbueringer changed the title Add release tasks doc and corresponding issue template 📖 Add release tasks doc and corresponding issue template Nov 4, 2022
@sbueringer
Copy link
Member Author

@ykakarap @dntosas @cpanato @hackeramitkumar
@oscr @sayantani11 @VibhorChinda
@furkatgofurov7 @nawazkh @aniruddha2000 @alexander-demicev

@CecileRobertMichon @enxebre @fabriziopandini @vincepri

Hey folks, please take a look :)

nawazkh
nawazkh reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@nawazkh nawazkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together!
I just have one request to update my slack user ID in the doc below :)

docs/release/release-1.4.md Outdated Show resolved Hide resolved
CecileRobertMichon
CecileRobertMichon reviewed Nov 4, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/feature_request.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_tracking.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_tracking.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_tracking.md Outdated Show resolved Hide resolved
docs/release/release-team.md Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outstanding work, kudos!
only a few nits from my side.

@ykakarap let's make sure all the folks in the release team take a look at this PR, but also that everyone is aware that we can improve this iteratively in follow up PRs

docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
@ykakarap
Copy link
Contributor

ykakarap commented Nov 8, 2022

cc @kubernetes-sigs/cluster-api-release-team

@sbueringer
Copy link
Member Author

sbueringer commented Nov 8, 2022 •
edited
Loading

Fixed some of the easier findings. Will push another commit with the ones that take more time soon.

@sbueringer
Copy link
Member Author

cc @joekr (PTAL :))

joekr
joekr reviewed Nov 8, 2022
View reviewed changes
docs/release/release-tasks.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member Author

sbueringer commented Nov 9, 2022 •
edited
Loading

Thank you very much for the reviews. All findings should be addressed or answered.

I updated the example issue accordingly:

Also testing the process for v1.3: #7527 (as applicable)

@hackeramitkumar
Copy link
Member

/lgtm

@hackeramitkumar
Copy link
Member

@sbueringer , Before merging this PR , we should squash the commits to a single commit.

@sbueringer
Copy link
Member Author

Before merging this PR , we should squash the commits to a single commit.

Will do, just waiting to get the conversations above resolved and consensus. Then it's a quick squash + lgtm/approve.

@CecileRobertMichon
Copy link
Contributor

/lgtm

I think this is a great start, huge thank you @sbueringer for putting this together so thoroughly and eloquently 💯

This will be a living doc and the release team and docs manager (@oscr 👀) can keep improving it as we go but I'm in favor of merging this for now so we have it in place for the v1.4 release cycle start.

@dntosas
Copy link
Contributor

dntosas commented Nov 17, 2022

thnx for your effort @sbueringer , nice and essential work 🚀

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2022
@sbueringer
Copy link
Member Author

sbueringer commented Nov 17, 2022 •
edited
Loading

Everything should be adressed now + squashed:

  • added a note about alphabetically sorting release note entries
  • added a note about checking for CI signal as a first step in cutting a release
  • added a note in release-team.md to link to release-tasks
  • updated release date for v1.2.x releases during the v1.4 release cycle

Thx for the reviews :)

@sbueringer
Copy link
Member Author

Given all the lgtm's above I would merge this relatively soon
@fabriziopandini WDYT?

@fabriziopandini
Copy link
Member

/lgtm
/approve
Go for it! feel free to unhold at your convenience
Echoing from slack:
This doc provides a great foundation for the first iteration; let’s merge it asap, keep track of areas of improvement in issues, and iterate while we learn during the next cycle

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@fabriziopandini
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2022
@sbueringer
Copy link
Member Author

Thx!
I'll merge tomorrow if there are no objections until then together with the other "lazy consensus" PRs.

@sbueringer sbueringer mentioned this pull request Nov 17, 2022
Merged
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 27c89c2 into kubernetes-sigs:main Nov 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 18, 2022
@sbueringer
Copy link
Member Author

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 18, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7563

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-release-tasks branch November 18, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr left review comments

@oscr oscr oscr left review comments

@stmcginnis stmcginnis stmcginnis left review comments

@cpanato cpanato cpanato left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@alexander-demicev alexander-demicev alexander-demicev left review comments

@ykakarap ykakarap ykakarap left review comments

@nawazkh nawazkh nawazkh left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@hackeramitkumar hackeramitkumar hackeramitkumar left review comments

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@cpanato cpanato

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

@hackeramitkumar hackeramitkumar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.