Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Get Ginkgo version in Makefile from go.mod #7503

Merged

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Nov 6, 2022

What this PR does / why we need it:

Exploring a way to avoid having to hardcode dependency versions in the Makefile that already exist in go.mod.

This would allow having dependabot bump these dependencies automatically to get a) notification of new versions b) knowledge of breakage asap.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2022
@oscr
Copy link
Contributor Author

oscr commented Nov 6, 2022

/test all

@oscr oscr force-pushed the backup-makefile-get-go-version branch from d7ad76f to faa7575 Compare November 6, 2022 16:32
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2022
@oscr
Copy link
Contributor Author

oscr commented Nov 6, 2022

/retest

@oscr
Copy link
Contributor Author

oscr commented Nov 6, 2022

cc @sbueringer Semi related to the discussion about make. A wild idea to get the version from go.mod. Only works for the dependencies in the mod file. Mainly to allow dependabot to bump dependencies and find breakages automatically in new versions. I'm not sure if it's a good idea yet 😁

@oscr oscr force-pushed the backup-makefile-get-go-version branch from faa7575 to b4f1209 Compare November 6, 2022 20:42
@oscr
Copy link
Contributor Author

oscr commented Nov 7, 2022

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2022
@sbueringer
Copy link
Member

sbueringer commented Nov 24, 2022

@oscr Somehow missed this PR entirely. GIven that we recently forgot to bump the ginkgo binary when we bumped the dependency...

I'm in favor of this PR as to me it's a good incremental improvement to guarantee versions are sync

@oscr oscr force-pushed the backup-makefile-get-go-version branch from b4f1209 to cfc1b67 Compare November 24, 2022 13:32
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2022
@oscr oscr marked this pull request as ready for review November 24, 2022 13:32
@oscr oscr changed the title [WIP] ✨ Get Makefile dependency versions from go.mod ✨ Get Ginkgo version in Makefile from go.mod Nov 24, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
@sbueringer
Copy link
Member

Thx!

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@fabriziopandini
Copy link
Member

Thanks for proposing this change @oscr, nice idea!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@fabriziopandini
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 13616a3 into kubernetes-sigs:main Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 28, 2022
@oscr oscr deleted the backup-makefile-get-go-version branch November 28, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants