Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Adds webhook TLS config info to the migration doc #7511

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

srm09
Copy link
Contributor

@srm09 srm09 commented Nov 7, 2022

What this PR does / why we need it:
This PR adds the webhook TLS configuration info and utility function usage suggestion to the migration docs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes n/a

Checkout this comment for background on this PR

Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2022
@sbueringer
Copy link
Member

/lgtm

We'll bring this up in the office hours on Wednesday

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
for the office hours

@sbueringer
Copy link
Member

/hold
for office hours

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@elmiko
Copy link
Contributor

elmiko commented Nov 9, 2022

as discussed in the community meeting from 9 November, looking to see if anyone has objections to adding this contract/advice, the work is ultimately on the providers.

if there are no objections by friday 11 November, we would like to merge this.

@fabriziopandini
Copy link
Member

/lgtm
/approve
as per comment above let's keep the hold till friday

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit d1173b9 into kubernetes-sigs:main Nov 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants