Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨add kubekey k3s boostrap and control plane provider #7528

Merged
merged 2 commits into from
Nov 16, 2022
Merged

✨add kubekey k3s boostrap and control plane provider #7528

merged 2 commits into from
Nov 16, 2022

Conversation

24sama
Copy link
Contributor

@24sama 24sama commented Nov 10, 2022 •
edited

What this PR does / why we need it:
add kubekey k3s boostrap and control plane provider.

This provider uses https://get.k3s.io script to install a k3s cluster.
Tested successfully with KubeKey provider (CAPKK), and other infra providers may need to prepare an os image that contains K3s binary and k3s-install.sh.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @24sama. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2022
@24sama 24sama changed the title add kubekey k3s boostrap and control plane provider ✨add kubekey k3s boostrap and control plane provider Nov 10, 2022
@24sama 24sama closed this Nov 10, 2022
@24sama 24sama reopened this Nov 10, 2022
killianmuldoon
killianmuldoon approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2022
@24sama
Copy link
Contributor Author

24sama commented Nov 10, 2022

/retest

@24sama
Copy link
Contributor Author

24sama commented Nov 10, 2022

/retest

@24sama
Copy link
Contributor Author

24sama commented Nov 10, 2022

/retest-required

@24sama
add kubekey k3s boostrap and control plane provider
6766d5c 
Signed-off-by: 24sama <jacksama@foxmail.com>
@24sama
Copy link
Contributor Author

24sama commented Nov 10, 2022

/retest

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2022
g-gaston
g-gaston approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
@24sama
Copy link
Contributor Author

24sama commented Nov 16, 2022 •
edited

/cc @sbueringer Please take a look.

@24sama
remove useless tab
1b32672 
Signed-off-by: 24sama <jacksama@foxmail.com>
killianmuldoon
killianmuldoon reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Was able to install all three kubekey providers with clusterctl init 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
@sbueringer
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit fa3ebdc into kubernetes-sigs:main Nov 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 16, 2022
@24sama 24sama mentioned this pull request Nov 17, 2022
Merged
@sbueringer
Copy link
Member

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 17, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7554

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@makhov makhov mentioned this pull request Oct 6, 2023
Closed
@killianmuldoon killianmuldoon mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@g-gaston g-gaston g-gaston approved these changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@24sama @k8s-ci-robot @fabriziopandini @sbueringer @k8s-infra-cherrypick-robot @g-gaston @killianmuldoon