-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add Settings support to RuntimeExtensions #7562
✨ add Settings support to RuntimeExtensions #7562
Conversation
b75e755
to
b261f56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me (mostly nits)
What about adding a stronger test signal by addressing #7322 (comment) within this PR as well? (feel free to say no)
@sbueringer @killianmuldoon opinions on ^^
internal/controllers/topology/cluster/patches/external/external_patch_generator.go
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator.go
Show resolved
Hide resolved
Sounds good to me |
Sounds good to me. I will make the change in this PR. |
Sounds good. Please let me know if/when I should review the PR, as usual I'm ignoring WIP PRs except if I'm asked for feedback/review. |
1e29b67
to
eccf25f
Compare
@sbueringer This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work
A few findings, but nothing big.
internal/controllers/topology/cluster/patches/external/external_patch_generator.go
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for me pending comments
eccf25f
to
103073a
Compare
103073a
to
95158a3
Compare
@ykakarap: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
great work! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds
Settings
support to RuntimeExtensions. Settings can be used to send arbitrary key value pairs in the request body of the call to the runtime extension.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #7432