Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add Settings support to RuntimeExtensions #7562

Merged
merged 1 commit into from
Dec 6, 2022
Merged

✨ add Settings support to RuntimeExtensions #7562

merged 1 commit into from
Dec 6, 2022

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR adds Settings support to RuntimeExtensions. Settings can be used to send arbitrary key value pairs in the request body of the call to the runtime extension.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7432

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2022
@ykakarap ykakarap force-pushed the runtimesdk-runtimeextensions-settings branch 2 times, most recently from b75e755 to b261f56 Compare November 18, 2022 08:34
@fabriziopandini fabriziopandini mentioned this pull request Nov 18, 2022
Closed
fabriziopandini
fabriziopandini reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me (mostly nits)
What about adding a stronger test signal by addressing #7322 (comment) within this PR as well? (feel free to say no)
@sbueringer @killianmuldoon opinions on ^^

exp/runtime/hooks/api/v1alpha1/common_types.go Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator.go Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator.go Show resolved Hide resolved
@sbueringer
Copy link
Member

What about adding a stronger test signal by addressing #7322 (comment) within this PR as well? (feel free to say no)
@sbueringer @killianmuldoon opinions on ^^

Sounds good to me

@ykakarap
Copy link
Contributor Author

PR looks good to me (mostly nits)
What about adding a stronger test signal by addressing #7322 (comment) within this PR as well? (feel free to say no)
@sbueringer @killianmuldoon opinions on ^^

Sounds good to me. I will make the change in this PR.

@sbueringer
Copy link
Member

Sounds good.

Please let me know if/when I should review the PR, as usual I'm ignoring WIP PRs except if I'm asked for feedback/review.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2022
@ykakarap ykakarap force-pushed the runtimesdk-runtimeextensions-settings branch from 1e29b67 to eccf25f Compare November 23, 2022 23:01
@ykakarap ykakarap changed the title ✨ [WIP] add Settings support to RuntimeExtensions ✨ add Settings support to RuntimeExtensions Nov 24, 2022
@ykakarap
Copy link
Contributor Author

@sbueringer This is ready for review.

sbueringer
sbueringer reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work

A few findings, but nothing big.

api/v1beta1/clusterclass_types.go Outdated Show resolved Hide resolved
exp/runtime/api/v1alpha1/extensionconfig_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/common_types.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator.go Show resolved Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator_test.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/patches/external/external_patch_generator.go Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
test/extension/handlers/lifecycle/handlers.go Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for me pending comments

@ykakarap ykakarap force-pushed the runtimesdk-runtimeextensions-settings branch from eccf25f to 103073a Compare December 5, 2022 21:24
@ykakarap ykakarap force-pushed the runtimesdk-runtimeextensions-settings branch from 103073a to 95158a3 Compare December 5, 2022 22:15
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 5, 2022 •
edited

@ykakarap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 95158a3 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

great work!
/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit f73b00d into kubernetes-sigs:main Dec 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Dec 6, 2022
@killianmuldoon killianmuldoon mentioned this pull request Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Support settings for RuntimeExtensions
4 participants
@ykakarap @sbueringer @k8s-ci-robot @fabriziopandini