-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Fix outdated enabling PodSecurityStandard env variable in CAPI quickstart #7566
📖 Fix outdated enabling PodSecurityStandard env variable in CAPI quickstart #7566
Conversation
|
Welcome @criscola! |
Hi @criscola. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@criscola Thx! Change looks good. Can you please take a look at the CLA? #7566 (comment) Thank you! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
(Pending CLA)
/easycla |
Oh and found also the older |
Thanks @criscola !
Yes I think it would be super awesome to keep it consistent. I'm also noting that we may should have used |
/lgtm |
/ok-to-test |
test/infrastructure/docker/templates/cluster-template-development.yaml
Outdated
Show resolved
Hide resolved
/lgtm cancel |
@criscola Do you have time to address the finding above? |
Of course! I committed the suggestion, thanks for the ping. Let me know if there's anything else. |
Thank you, looks good. One last thing, can you please squash the commits? |
lgtm pending squash |
@criscola ^^ |
4cfc147
to
ec7369b
Compare
There you go @sbueringer |
Thx! /lgtm /cherry-pick release-1.3 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM label has been added. Git tree hash: e75558ad539ad7400a5f8ff1f2e801a0c47f171c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #7962 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
I found out
POD_SECURITY_STANDARD_ENABLED
in CAPI quickstart for CAPD was wrong/outdated.I changed it to
ENABLE_POD_SECURITY_STANDARD
which now enables/disables the PodSecurityStandard variable in the manifest generated byclusterctl
correctly.