Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix outdated enabling PodSecurityStandard env variable in CAPI quickstart #7566

Merged
merged 1 commit into from
Jan 20, 2023
Merged

📖 Fix outdated enabling PodSecurityStandard env variable in CAPI quickstart #7566

merged 1 commit into from
Jan 20, 2023

Conversation

criscola
Copy link
Contributor

What this PR does / why we need it:

I found out POD_SECURITY_STANDARD_ENABLED in CAPI quickstart for CAPD was wrong/outdated.
I changed it to ENABLE_POD_SECURITY_STANDARD which now enables/disables the PodSecurityStandard variable in the manifest generated by clusterctl correctly.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: criscola / name: Cristiano Colangelo (14a7ac0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 18, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @criscola!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @criscola. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2022
@sbueringer
Copy link
Member

@criscola Thx!

Change looks good. Can you please take a look at the CLA? #7566 (comment) Thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
killianmuldoon
killianmuldoon reviewed Nov 18, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(Pending CLA)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 18, 2022
@criscola
Copy link
Contributor Author

/easycla

@criscola
Copy link
Contributor Author

Oh and found also the older POD_SECURITY_STANDARD_ENABLED in file test/infrastructure/docker/templates/cluster-template-development.yaml, should this also be replaced?

@chrischdi
Copy link
Member

Thanks @criscola !

Oh and found also the older POD_SECURITY_STANDARD_ENABLED in file test/infrastructure/docker/templates/cluster-template-development.yaml, should this also be replaced?

Yes I think it would be super awesome to keep it consistent.

I'm also noting that we may should have used ACTIVATED instead of ENABLED when adding that code 🤔 (xref https://inclusivenaming.org/word-lists/no-change/disable/ ) but I would keep that out of scope for this fix 👍

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 18, 2022
@chrischdi
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@sbueringer
Copy link
Member

@criscola Do you have time to address the finding above?

@criscola
Copy link
Contributor Author

criscola commented Jan 19, 2023 •
edited
Loading

Of course! I committed the suggestion, thanks for the ping. Let me know if there's anything else.

@sbueringer
Copy link
Member

Of course! I committed the suggestion, thanks for the ping. Let me know if there's anything else.

Thank you, looks good.

One last thing, can you please squash the commits?

@fabriziopandini
Copy link
Member

lgtm pending squash

@sbueringer
Copy link
Member

sbueringer commented Jan 20, 2023 •
edited
Loading

@criscola ^^
(forgot the mention before)

@criscola criscola force-pushed the pr-update-podsecuritystandard-envvar-docs branch from 4cfc147 to ec7369b Compare January 20, 2023 15:16
@criscola
Copy link
Contributor Author

There you go @sbueringer

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

Thx!

/lgtm
/approve

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e75558ad539ad7400a5f8ff1f2e801a0c47f171c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit d98ae0e into kubernetes-sigs:main Jan 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 20, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 20, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7962

In response to this:

Thx!

/lgtm
/approve

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@criscola @k8s-ci-robot @sbueringer @chrischdi @fabriziopandini @k8s-infra-cherrypick-robot @killianmuldoon