Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Removed the writing of os.environment by passing the 'env' parameter in cmd_button #7574

Merged
merged 1 commit into from
Nov 23, 2022
Merged

✨ Removed the writing of os.environment by passing the 'env' parameter in cmd_button #7574

merged 1 commit into from
Nov 23, 2022

Conversation

chiukapoor
Copy link
Contributor

Signed-off-by: Chirayu Kapoor dev.csociety@gmail.com

What this PR does / why we need it:
The PR removes the writing of os.environment by passing the env parameter in cmd_button

A new function called dictonary_to_list_of_string is added because the env parameter of cmd_button requires a list of strings of format "name=value". Eg: ["env1=val1", "env2=val2"]

Which issue(s) this PR fixes
Fixes #7430

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @chiukapoor. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2022
@chiukapoor
Copy link
Contributor Author

CC: @sbueringer

sbueringer
sbueringer reviewed Nov 21, 2022
View reviewed changes
Tiltfile Show resolved Hide resolved
@chiukapoor
Copy link
Contributor Author

Hello @CecileRobertMichon and @stmcginnis, Hope you are doing well!

PTAL

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2022
sbueringer
sbueringer reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise looks good!
(I also verified it locally and works as expected)

Thank you!

Can you please also squash the commits?

Tiltfile Show resolved Hide resolved
@chiukapoor
Removed the writing of os.environment by passing the 'env' parameter …
f4c74fe 
…in cmd_button | Bumping the minimum supported Tilt version to v0.30.8
@sbueringer
Copy link
Member

Thx!

I'll give other folks some time for review.

Feel free to ping me next week for merge if this PR wasn't merged in the meantime

(we have a lot of stuff going on with the upcoming release right now)

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
fabriziopandini
fabriziopandini reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks for implementing this change!

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit d84af40 into kubernetes-sigs:main Nov 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 23, 2022
@chiukapoor chiukapoor mentioned this pull request Dec 2, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Avoid writing environment variables in Tiltfile
4 participants
@chiukapoor @k8s-ci-robot @sbueringer @fabriziopandini