-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Removed the writing of os.environment by passing the 'env' parameter in cmd_button #7574
✨ Removed the writing of os.environment by passing the 'env' parameter in cmd_button #7574
Conversation
Hi @chiukapoor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CC: @sbueringer |
Hello @CecileRobertMichon and @stmcginnis, Hope you are doing well! PTAL |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. Otherwise looks good!
(I also verified it locally and works as expected)
Thank you!
Can you please also squash the commits?
…in cmd_button | Bumping the minimum supported Tilt version to v0.30.8
456eac9
to
f4c74fe
Compare
Thx! I'll give other folks some time for review. Feel free to ping me next week for merge if this PR wasn't merged in the meantime (we have a lot of stuff going on with the upcoming release right now) |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks for implementing this change!
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Chirayu Kapoor dev.csociety@gmail.com
What this PR does / why we need it:
The PR removes the writing of
os.environment
by passing theenv
parameter incmd_button
A new function called
dictonary_to_list_of_string
is added because theenv
parameter ofcmd_button
requires a list of strings of format"name=value"
. Eg: ["env1=val1", "env2=val2"]Which issue(s) this PR fixes
Fixes #7430