-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Introduce additional linters & bump golangci-lint to 1.50.1 #7581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from my side
@oscr @sbueringer who did recent work in this area
Thanks for the contribution @Prajyot-Parab 😃 IMO it would be better not to include It would be awesome if you could enable a pattern in the settings for |
I agree with @killianmuldoon summary. @Prajyot-Parab Thank you for your help. There are some good checks here that we are missing. |
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
Thank you for helping us explore the vast area of linters! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
/lgtm
Thx @Prajyot-Parab Can you please update the PR description to reflect the linters that were eventually added via this PR? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Prajyot-Parab prajyot.parab2@ibm.com
What this PR does / why we need it:
Here are the descriptions of the new linters this PR proposes to add:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #