Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix adopting ClusterResourceSet resource by CRS when already applied #7590

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Ensure Resources owned by a ClusterResourceSet will be adopted on reconciles where the resource isn't applied.

Part of #7575

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2022
@killianmuldoon killianmuldoon changed the title Fix adopting ClusterResourceSet resource by CRS when already applied 🐛 Fix adopting ClusterResourceSet resource by CRS when already applied Nov 22, 2022
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit, otherwise lgtm

@sbueringer
Copy link
Member

lgtm pending Fabrizio's comments

@killianmuldoon killianmuldoon changed the title 🐛 Fix adopting ClusterResourceSet resource by CRS when already applied 🐛 [WIP] Fix adopting ClusterResourceSet resource by CRS when already applied Nov 23, 2022
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@fabriziopandini fabriziopandini changed the title 🐛 [WIP] Fix adopting ClusterResourceSet resource by CRS when already applied 🐛 Fix adopting ClusterResourceSet resource by CRS when already applied Nov 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6c65434 into kubernetes-sigs:main Nov 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 23, 2022
@sbueringer
Copy link
Member

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #7601

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@sbueringer: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api#release-1.3 from head k8s-infra-cherrypick-robot:cherry-pick-7590-to-release-1.3: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-1.3 and k8s-infra-cherrypick-robot:cherry-pick-7590-to-release-1.3"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #7608

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants