-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adds a make target to generate all the release manifests #7629
✨ Adds a make target to generate all the release manifests #7629
Conversation
Signed-off-by: Chirayu Kapoor <dev.csociety@gmail.com>
Hi @chiukapoor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Thanks for preparing this!
/lgtm @killianmuldoon I assume this is what you were looking for? |
/cherry-pick release-1.3 I would like to cherry-pick this into 1.3 - ideally before v1.3.0. Just to have it directly verified vs. in 3 months during the first v1.4 beta. |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve @killianmuldoon Feel free to hold cancel if the PR is fine for you. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @chiukapoor!
/lgtm
/remove-hold
@sbueringer: new pull request created: #7660 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Chirayu Kapoor dev.csociety@gmail.com
What this PR does / why we need it:
Adds make target
release-manifests-all
to generate all the release manifests independently ofmake release
This PR helps the users and developers as
make release-binaries
takes considerable time.Which issue(s) this PR fixes
Fixes #6975