Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [kcp] Make kcp.skipPhases field mutable #7646

Merged
merged 1 commit into from
Nov 29, 2022
Merged

✨ [kcp] Make kcp.skipPhases field mutable #7646

merged 1 commit into from
Nov 29, 2022

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Nov 28, 2022 •
edited

What this PR does / why we need it:
Makes KCP skipPhases field mutable, needed in cases like disabling kube-proxy deployment on an existing cluster.

Signed-off-by: Jim Ntosas ntosas@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2022
@dntosas dntosas force-pushed the feat/make-skip-phases-mutable-on-kcp branch from 0ec3043 to 40cb02f Compare November 28, 2022 13:34
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2022
@dntosas dntosas changed the title ✨ [kcp] Make initConfiguration.skipPhases field mutable ✨ [kcp] Make kcp.skipPhases field mutable Nov 28, 2022
@dntosas dntosas force-pushed the feat/make-skip-phases-mutable-on-kcp branch from 40cb02f to bd43b2b Compare November 28, 2022 13:35
@dntosas
[kcp] Make kcp.skipPhases field mutable
650b187 
Makes KCP skipPhases field mutable, needed in cases like disabling
kube-proxy deployment on an existing cluster.

Signed-off-by: Jim Ntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the feat/make-skip-phases-mutable-on-kcp branch from bd43b2b to 650b187 Compare November 28, 2022 13:45
@dntosas
Copy link
Contributor Author

dntosas commented Nov 28, 2022

/retest

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@sbueringer
Copy link
Member

sbueringer commented Nov 29, 2022 •
edited

/lgtm
/approve

I'm going to cherry-pick this into release-1.3. I don't see any harm in doing so (it's low impact) and from the point of view of someone who wants to mutate those fields it's a bugfix.

@sbueringer
Copy link
Member

/cherry-pick release-1.3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2e7b8f8 into kubernetes-sigs:main Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 29, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 29, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7655

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dntosas dntosas deleted the feat/make-skip-phases-mutable-on-kcp branch November 29, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dntosas @fabriziopandini @sbueringer @k8s-ci-robot @k8s-infra-cherrypick-robot