[release-1.2] 🐛 Fix KubeadmControlPlane secrets should always be adopted #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
force-pushed
the
pr-adoption-cherry-pick-1.2
branch
from
d34dded
to
3531c45
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
sbueringer
force-pushed
the
pr-adoption-cherry-pick-1.2
branch
from
3531c45
to
0f3a132
Compare
k8s-ci-robot
added
size/L
|
|
||
| t.Run("replace non-KCP controller with KCP controller reference", func(t *testing.T) { | ||
| objs := []client.Object{fakeGenericMachineTemplateCRD, cluster.DeepCopy(), kcp.DeepCopy(), tmpl.DeepCopy()} | ||
| // A simulacrum of the various Certificate and kubeconfig secrets |
There was a problem hiding this comment.
One nit (I can do it in a follow up if you'd like as it's my mistake) this comment doesn't belong here - whole thing can be removed.
There was a problem hiding this comment.
I'll do this with a cherry pick actually
There was a problem hiding this comment.
Yup. It's the same on main, right?
|
/lgtm For the comment we can cherry-pick #7662 |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon kmuldoon@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Manual cherry-pick of #7592