-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix flakiness in MD controller test #7668
🐛 Fix flakiness in MD controller test #7668
Conversation
85e0771
to
541c5b9
Compare
/test ? |
@killianmuldoon: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-test-main |
4 similar comments
/test pull-cluster-api-test-main |
/test pull-cluster-api-test-main |
/test pull-cluster-api-test-main |
/test pull-cluster-api-test-main |
541c5b9
to
8b47a78
Compare
@@ -394,7 +394,7 @@ func TestMachineDeploymentReconciler(t *testing.T) { | |||
return false | |||
} | |||
return machineSets.Items[0].Status.Replicas == *deployment.Spec.Replicas | |||
}, timeout*5).Should(BeTrue()) | |||
}, timeout*10).Should(BeTrue()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see an easy win here for this deletion - I think the best thing to do for now is to increase the timeout for the test from 150 seconds to 300 seconds and see if long tail reconciliation always happens within that window
8b47a78
to
8b3c3cf
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
8b3c3cf
to
e9cce67
Compare
Taking another look at this I think we should merge as is and monitor to see if the test stays flaky. Seems to me there's a long tail on deletion in the test which is just hard to account for deterministically. If lengthening the max timeout doesn't work we can consider rewriting the test - possibly to make this check occur later in the order. |
internal/controllers/machinedeployment/machinedeployment_controller_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
let's see if this improves the situation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.2 |
/cherry-pick release-1.3 Cherry picking this fix as we've seen the flake a number of times in supported branches. |
@killianmuldoon: new pull request created: #7753 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #7754 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon kmuldoon@vmware.com
Fix flakiness in MD controller test when verifying the deletion of old MachineSets.