-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: add Cluster API 1.4 and Kubernetes 1.26 to supported versions page #7696
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a blocker from this PR, but I think we should consider removing v1.0 and v1.1 from these tables. We now have two supported releases, and users can review those versions of the book if they want the correct version support for those releases.
I think v0.3 and v0.4 are different cases as they're different API versions, but we could also consider removing those in favor of keeping their compatibility information in their versions of the book.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another question: should the lowest supported Kubernetes version change? CAPI supports a lot of versions that aren't being developed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CAPI support policy has been to assume that version of Kubernetes works up until there's a signal that it doesn't, or an actual breaking change.
There's still tests being run against these older versions of K8s too - so the community would have to make an affirmative decision to stop supporting some of these older versions IMO - possibly a good question for a community meeting.
There's also a couple of related issues open to enforce this in webhooks (at least for KCP) e.g. #7010. Today we don't enforce the versions of Kubernetes at all, so that would definitely be a start IMO, but it would create a situation where choosing to not support a version becomes explicit and strict i.e. someone has to make a PR that will block Kubernetes 1.16 in KCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will bring up discussions next year in January to discuss a few of our support policies where this will be included.