Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove clusterctl backup command and Backup function from Client interface #7752

Merged
merged 1 commit into from
Dec 29, 2022
Merged

⚠️ Remove clusterctl backup command and Backup function from Client interface #7752

merged 1 commit into from
Dec 29, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Dec 13, 2022

What this PR does / why we need it:

  • Removes the clusterctl backup command
  • Removes the Backup function in Client interface
  • Removes tests
  • Updates docs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #7713

@k8s-ci-robot
Copy link
Contributor

@oscr: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oscr
Copy link
Contributor Author

oscr commented Dec 13, 2022

/test pull-cluster-api-e2e-full-main

killianmuldoon
killianmuldoon reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI isn't running at all?

@oscr
Copy link
Contributor Author

oscr commented Dec 13, 2022

No, seems like there is an issue with CI.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2022
@ykakarap ykakarap mentioned this pull request Dec 13, 2022
Closed
8 tasks
@oscr
Copy link
Contributor Author

oscr commented Dec 13, 2022

apidiff failure is expected since it actually changes the api

   Incompatible changes:
  - ObjectMover.Backup: removed
sigs.k8s.io/cluster-api/cmd/clusterctl/client
  Incompatible changes:
  - (*clusterctlClient).Backup: removed
  - BackupOptions: removed
  - Client.Backup: removed

Jont828
Jont828 reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@Jont828 Jont828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Everything seems reasonable to me, I don't see anything wrong that stands out. Are there any e2e tests that rely on this/would we need to update anything in test-infra?

@oscr
Copy link
Contributor Author

oscr commented Dec 14, 2022

/test pull-cluster-api-e2e-full-main

@oscr
Copy link
Contributor Author

oscr commented Dec 14, 2022

Thanks for the contribution! Everything seems reasonable to me, I don't see anything wrong that stands out. Are there any e2e tests that rely on this/would we need to update anything in test-infra?

Thanks @Jont828! I searched for it and the pull-cluster-api-e2e-full-main test passes so I hope it should be fine. apidiff test failure is expected since it changes :)

@ykakarap
Copy link
Contributor

Overall looks good. I will take another pass to see if any of our test need to be adjusted for this.
And yes, the apidiff is expected.

ykakarap
ykakarap approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
fabriziopandini
fabriziopandini reviewed Dec 18, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscr
Thanks for working on this issue!
Let's keep the unit tests so we can exercise the clusterctl backup replacement (toDirectory)
Also could you please remove the comment about clusterctl backup from https://cluster-api.sigs.k8s.io/clusterctl/commands/commands.html
Oterwise lgtm for me

cmd/clusterctl/client/cluster/mover_test.go Show resolved Hide resolved
cmd/clusterctl/client/move_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2022
@k8s-ci-robot
Copy link
Contributor

@oscr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main cbcf6d5 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

/lgtm
/approve

Thanks for this cleanup! next up is restore!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3c15055ec41c2e034a83b3a46ce55ad88eff130

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9845887 into kubernetes-sigs:main Dec 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Dec 29, 2022
@oscr oscr deleted the clusterctl-backup-remove branch December 29, 2022 18:24
@fabriziopandini fabriziopandini changed the title 🌱 Remove clusterctl backup command and Backup function from Client interface ⚠️ Remove clusterctl backup command and Backup function from Client interface Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@Jont828 Jont828 Jont828 left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@ykakarap ykakarap ykakarap approved these changes

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@oscr @k8s-ci-robot @ykakarap @fabriziopandini @Jont828 @killianmuldoon