-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove clusterctl backup
command and Backup function from Client interface
#7752
⚠️ Remove clusterctl backup
command and Backup function from Client interface
#7752
Conversation
@oscr: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI isn't running at all?
No, seems like there is an issue with CI. |
836ac6a
to
b87f119
Compare
apidiff failure is expected since it actually changes the api
|
b87f119
to
b1ded67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Everything seems reasonable to me, I don't see anything wrong that stands out. Are there any e2e tests that rely on this/would we need to update anything in test-infra?
/test pull-cluster-api-e2e-full-main |
Thanks @Jont828! I searched for it and the |
Overall looks good. I will take another pass to see if any of our test need to be adjusted for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oscr
Thanks for working on this issue!
Let's keep the unit tests so we can exercise the clusterctl backup replacement (toDirectory)
Also could you please remove the comment about clusterctl backup from https://cluster-api.sigs.k8s.io/clusterctl/commands/commands.html
Oterwise lgtm for me
b1ded67
to
b73792a
Compare
b73792a
to
292c3e5
Compare
292c3e5
to
cbcf6d5
Compare
@oscr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm Thanks for this cleanup! next up is restore! |
LGTM label has been added. Git tree hash: c3c15055ec41c2e034a83b3a46ce55ad88eff130
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
clusterctl backup
command and Backup function from Client interfaceclusterctl backup
command and Backup function from Client interface
What this PR does / why we need it:
clusterctl backup
commandBackup
function in Client interfaceWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #7713