Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 🌱 Fix verify-shellcheck script and fix findings #7757

Closed
wants to merge 8 commits into from
Closed

[release-1.2] 🌱 Fix verify-shellcheck script and fix findings #7757

wants to merge 8 commits into from

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Dec 13, 2022

What this PR does / why we need it:

The verify-shellcheck script exited after grep didn't find any matches. This fix enables the script to continue.

This will hopefully allow #7749 to merge.

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 13, 2022
killianmuldoon
killianmuldoon approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
k8s-ci-robot and others added 5 commits December 13, 2022 17:17
@k8s-ci-robot
Merge pull request kubernetes-sigs#7505 from k8s-infra-cherrypick-rob…
373ee42 
…ot/cherry-pick-7471-to-release-1.2

[release-1.2] 🌱 KCP: use new registry for Kubernetes >= v1.22
@ykakarap
restrict machine deployment topology name to less than 63 characters
d6f4fb8
@killianmuldoon
Add deterministic prefix and suffix to label hash
4186f46 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot
Merge pull request kubernetes-sigs#7762 from k8s-infra-cherrypick-rob…
43b35ba 
…ot/cherry-pick-7759-to-release-1.2

[release-1.2] 🐛 Validate MachineDeploymentTopology.Name to be valid label value
@k8s-ci-robot
Merge pull request kubernetes-sigs#7765 from k8s-infra-cherrypick-rob…
6033bcf 
…ot/cherry-pick-7763-to-release-1.2

[release-1.2] 🐛 Add deterministic prefix and suffix to label hash
ykakarap
ykakarap approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini fabriziopandini changed the title 🌱 Fix verify-shellcheck script and fix findings [release-1.2] 🌱 Fix verify-shellcheck script and fix findings Dec 18, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2022
@k8s-ci-robot
Merge pull request kubernetes-sigs#7757 from oscr/add-lint-fix
c569e4d 
[release-1.2] 🌱 Fix verify-shellcheck script and fix findings
@k8s-ci-robot
Copy link
Contributor

@oscr: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2022
@oscr oscr closed this Dec 19, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2022
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2022
@oscr
Copy link
Contributor Author

oscr commented Dec 19, 2022

@ykakarap @killianmuldoon @fabriziopandini @sbueringer Really strange behavior here. This pr was approved 2h ago and it looks like it actually merged (from git history) but the pr wasn't closed. I got a message that it needed to be rebased so I rebased and pushed. After I pushed it was automatically closed, lgtm label was removed and now it says it was successfully merged.

@sbueringer sbueringer mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap approved these changes

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@oscr @fabriziopandini @k8s-ci-robot @ykakarap @killianmuldoon @sbueringer