-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ clusterctl: add command groups #7769
✨ clusterctl: add command groups #7769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64ae7b5
to
47ac8f9
Compare
47ac8f9
to
d49f2aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This is great. Thank you!
Right now the alpha
commands are a bucket of everything. Example alpha rollout
would best suite "Cluster Management Commands" group and alpha topology plan
would best suite "Troubleshooting and Debugging Commands" group. But since in this itearation we are only doing top level grouping the current grouping we have makes sense.
Great Stuff! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ykakarap @fabriziopandini Would you like me to also make prs for 1.3 and 1.2? |
In general we don't backport features https://github.com/kubernetes-sigs/cluster-api/blob/main/CONTRIBUTING.md#backporting-a-patch |
Nice feature, thx!! |
What this PR does / why we need it:
Improves the clusterctl command overview by grouping the commands. I opted to create two groups: "Management commands" and "Other commands". I welcome any feedback regarding the names.
This feature would also allow the flattening of the command structure in the future. For example the alpha commands could be placed under a "Alpha commands" group and displayed immediately under the help command.
New clusterctl output:
Old clusterctl output: