Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] 🌱 Bump actions/cache from 3.0.4 to 3.2.1 #7813

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Dec 29, 2022

Manual cherry-pick of #7805

Bumps actions/cache from 3.0.11 to 3.2.1.

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Dec 29, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 29, 2022
@fabriziopandini
Copy link
Member Author

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
@sbueringer
Copy link
Member

sbueringer commented Jan 2, 2023

@fabriziopandini Q: Why did we start to cherry-pick GitHub action bumps to older release branches? Just curious what the reasons behind it are, I assume as long as there are no CVE's in them (we never had that) it's not really worth the effort.

(just want to understand why we're doing it as it's a non-trivial amount of work with all the bump PRs from dependabot, I'm fine with doing it if we think it's worth the effort)

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Jan 2, 2023

We started backporting dependabot bumps due to CVE, then continued without thinking too much about discriminating bumps for CVE vs regular bumps vs GitHub actions bumps.
I'm ok with limiting the scope to only CVE if we want to, but in case let's clarify this into contributing guidelines so it became more visible.

@sbueringer
Copy link
Member

sbueringer commented Jan 2, 2023

I'll merge this PR given it's already open and ready and we backported the same to release-1.3

I'll open an issue to discuss a bit what kind of dependency bumps we want to pro-actively backport (+ follow-up policy update)

It's not really that I'm objecting to merging GitHub action bumps if someone wants to invest the effort to open the PRs. I just tend to not want to invest the effort to do it pro-actively I guess.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c18cc33172050b719e96e22bc25348538cd7fafc

@k8s-ci-robot k8s-ci-robot merged commit c4586d5 into kubernetes-sigs:release-1.2 Jan 2, 2023
@fabriziopandini fabriziopandini deleted the dependabot/github_actions/actions/cache-3.2.1 branch July 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants