Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Updating clusterawsadm Docs #7814

Merged

Conversation

luthermonson
Copy link
Contributor

What this PR does / why we need it:
cluster-api-provider-aws now releases windows binaries for clusterawsadm. This updates the curl links to be v2.0.0+ which has windows binaries in it's releases. Additionally this splits the *nix examples from the windows example and shows how to use clusterawsadm in powershell.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 29, 2022
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 01b1f11acfe06b349d770b7fa1c3899e65ceccd8

@fabriziopandini
Copy link
Member

/lgtm
/approve

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2022
@fabriziopandini
Copy link
Member

@luthermonson should we backport this to release 1.2 too?

@k8s-ci-robot k8s-ci-robot merged commit 02240ca into kubernetes-sigs:main Dec 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Dec 30, 2022
@k8s-infra-cherrypick-robot

@fabriziopandini: #7814 failed to apply on top of branch "release-1.3":

Applying: updating clusterawsadm docs to use v2.0.0+ which now supports windows binaries
Using index info to reconstruct a base tree...
M	docs/book/src/user/quick-start.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/user/quick-start.md
CONFLICT (content): Merge conflict in docs/book/src/user/quick-start.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 updating clusterawsadm docs to use v2.0.0+ which now supports windows binaries
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/lgtm
/approve

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

@luthermonson should we backport this to release 1.2 too?

I wonder if the old book(s) are read by users often enough to invest the effort (but of course no objection from my side)

@luthermonson
Copy link
Contributor Author

i agree that it wont really benefit many to have it in 1.2 or earlier docs, i'd be happy to make the PRs if you want it tho just let me know

@luthermonson luthermonson deleted the clusterawsadm-windows branch January 3, 2023 21:31
@sbueringer
Copy link
Member

That being said. A manual cherry-pick PR (given that the automatic cherry-pick failed here: #7814 (comment)) would be good.

Otherwise folks will only see the new documentation after the v1.4 release end of March

@luthermonson Would be great if you can open a PR against release-1.3 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants