-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Updating clusterawsadm Docs #7814
📖 Updating clusterawsadm Docs #7814
Conversation
/lgtm |
LGTM label has been added. Git tree hash: 01b1f11acfe06b349d770b7fa1c3899e65ceccd8
|
/lgtm /cherry-pick release-1.3 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@luthermonson should we backport this to release 1.2 too? |
@fabriziopandini: #7814 failed to apply on top of branch "release-1.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I wonder if the old book(s) are read by users often enough to invest the effort (but of course no objection from my side) |
i agree that it wont really benefit many to have it in 1.2 or earlier docs, i'd be happy to make the PRs if you want it tho just let me know |
That being said. A manual cherry-pick PR (given that the automatic cherry-pick failed here: #7814 (comment)) would be good. Otherwise folks will only see the new documentation after the v1.4 release end of March @luthermonson Would be great if you can open a PR against release-1.3 for that. |
What this PR does / why we need it:
cluster-api-provider-aws now releases windows binaries for clusterawsadm. This updates the curl links to be v2.0.0+ which has windows binaries in it's releases. Additionally this splits the *nix examples from the windows example and shows how to use
clusterawsadm
in powershell.