Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Small improvement to the backport policy #7823

Merged
merged 1 commit into from
Jan 9, 2023
Merged

🌱 Small improvement to the backport policy #7823

merged 1 commit into from
Jan 9, 2023

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Following up to some discussion on recent PRs, e.g #7817 (comment), I'm proposing some small changes to help us in better dealing with supporting multiple cluster API releases at the same time.

@vincepri @sbueringer @CecileRobertMichon @enxebre

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2023
@fabriziopandini fabriziopandini mentioned this pull request Jan 2, 2023
Merged
sbueringer
sbueringer reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Thank you!

Just some nits.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 503aa088d227e1b57f495cd68d98d4f080f7e860

@fabriziopandini
Copy link
Member Author

cc @killianmuldoon @ykakarap @kubernetes-sigs/cluster-api-release-team since we all had a fair amount of backports for the recent patch release bump

killianmuldoon
killianmuldoon approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cpanato
cpanato approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hackeramitkumar
Copy link
Member

/lgtm

furkatgofurov7
furkatgofurov7 reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit. otherwise lgtm

CONTRIBUTING.md Outdated Show resolved Hide resolved
schrej
schrej reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@schrej schrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of plural/singluar related nits. Not sure if that was intentional, but it should be consistent imo.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@schrej
Copy link
Member

schrej commented Jan 4, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 331bb7dc85f37dd1e28752f369f4ff1b047e762d

@sbueringer
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a3f77724806ddd2d7758f9e040929d162145dc7

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@fabriziopandini
Copy link
Member Author

Edited as per office hours discussion

elmiko
elmiko reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c554588c69505b723de4bf821c634a82ec5f5938

@hackeramitkumar
Copy link
Member

/lgtm

CecileRobertMichon
CecileRobertMichon reviewed Jan 4, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CecileRobertMichon
CecileRobertMichon reviewed Jan 4, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2023
sbueringer
sbueringer reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, just last round of nits

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7c1bb83394d7f4ae97e85ecee81acd92cc4c4844

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit ae6c59d into kubernetes-sigs:main Jan 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 9, 2023
@fabriziopandini fabriziopandini deleted the clarify-backport-policy branch January 30, 2023 09:32
@sbueringer
Copy link
Member

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 15, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #8114

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@cpanato cpanato Awaiting requested review from cpanato

@hackeramitkumar hackeramitkumar Awaiting requested review from hackeramitkumar

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@schrej schrej Awaiting requested review from schrej

@elmiko elmiko Awaiting requested review from elmiko

Assignees

@elmiko elmiko

@schrej schrej

@cpanato cpanato

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

@hackeramitkumar hackeramitkumar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.