-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Removing deprecated (--disable-no-echo) flag and renaming docs #7837
⚠️ Removing deprecated (--disable-no-echo) flag and renaming docs #7837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 4ddc1348f724e654339d99f9f26dbb78f7e7d8c3
|
4dd5f7b
to
3dc6eef
Compare
3dc6eef
to
07d608b
Compare
/test pull-cluster-api-e2e-informing-main |
also, could you kindly add one line for this change in https://main.cluster-api.sigs.k8s.io/developer/providers/v1.3-to-v1.4.html#removals (this is a doc provider look at when upgrading) |
07d608b
to
c236c8b
Compare
LGTM label has been added. Git tree hash: 53d58a75fa7684a5c2b3d970e4f51cbaf55c5364
|
c236c8b
to
ffccdaa
Compare
ffccdaa
to
1f0e0f4
Compare
@knabben: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1f0e0f4
to
4405fcd
Compare
/lgtm |
LGTM label has been added. Git tree hash: 7a58485c8d41a2fc2c232697806c5364332358eb
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Removing the
--disable-no-echo
flag and fixing docs for use of--echo
instead.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #7713