Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Removing deprecated (--disable-no-echo) flag and renaming docs #7837

Merged
merged 1 commit into from
Jan 4, 2023
Merged

⚠️ Removing deprecated (--disable-no-echo) flag and renaming docs #7837

merged 1 commit into from
Jan 4, 2023

Conversation

knabben
Copy link
Member

@knabben knabben commented Jan 3, 2023 •
edited

What this PR does / why we need it:
Removing the --disable-no-echo flag and fixing docs for use of --echo instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #7713

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 3, 2023
killianmuldoon
killianmuldoon approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4ddc1348f724e654339d99f9f26dbb78f7e7d8c3

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@knabben knabben changed the title 🌱 Removing not used flag and renaming docs 🌱 Removing deprecated (--disable-no-echo) flag and renaming docs Jan 3, 2023
@knabben
Copy link
Member Author

knabben commented Jan 3, 2023

/test pull-cluster-api-e2e-informing-main

@knabben knabben mentioned this pull request Jan 3, 2023
Closed
8 tasks
@fabriziopandini fabriziopandini changed the title 🌱 Removing deprecated (--disable-no-echo) flag and renaming docs ⚠️ Removing deprecated (--disable-no-echo) flag and renaming docs Jan 3, 2023
@fabriziopandini
Copy link
Member

also, could you kindly add one line for this change in https://main.cluster-api.sigs.k8s.io/developer/providers/v1.3-to-v1.4.html#removals (this is a doc provider look at when upgrading)

@fabriziopandini
Copy link
Member

/lgtm
@ykakarap @Jont828 PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53d58a75fa7684a5c2b3d970e4f51cbaf55c5364

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 4, 2023 •
edited

@knabben: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-informing-main 1f0e0f4 link false /test pull-cluster-api-e2e-informing-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@sbueringer
Copy link
Member

/lgtm
/approve
Thx!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a58485c8d41a2fc2c232697806c5364332358eb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit cc7b5ad into kubernetes-sigs:main Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 4, 2023
@knabben knabben deleted the remove-disable-no-echo branch January 4, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@ykakarap ykakarap Awaiting requested review from ykakarap

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@knabben @k8s-ci-robot @fabriziopandini @sbueringer @killianmuldoon