Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Removing deprecated --list-images flag on init command #7838

Merged
merged 1 commit into from
Jan 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions cmd/clusterctl/cmd/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ limitations under the License.
package cmd

import (
"fmt"
"time"

"github.com/spf13/cobra"
Expand All @@ -35,7 +34,6 @@ type initOptions struct {
ipamProviders []string
runtimeExtensionProviders []string
targetNamespace string
listImages bool
validate bool
waitProviders bool
waitProviderTimeout int
Expand Down Expand Up @@ -114,10 +112,6 @@ func init() {
initCmd.Flags().BoolVar(&initOpts.validate, "validate", true,
"If true, clusterctl will validate that the deployments will succeed on the management cluster.")

initCmd.Flags().BoolVar(&initOpts.listImages, "list-images", false,
"Lists the container images required for initializing the management cluster (without actually installing the providers)")
_ = initCmd.Flags().MarkDeprecated("list-images", "use 'clusterctl init list-images' instead.")

initCmd.AddCommand(initListImagesCmd)
RootCmd.AddCommand(initCmd)
}
Expand All @@ -143,18 +137,6 @@ func runInit() error {
IgnoreValidationErrors: !initOpts.validate,
}

if initOpts.listImages {
images, err := c.InitImages(options)
if err != nil {
return err
}

for _, i := range images {
fmt.Println(i)
}
return nil
}

if _, err := c.Init(options); err != nil {
return err
}
Expand Down
1 change: 1 addition & 0 deletions docs/book/src/developer/providers/v1.3-to-v1.4.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ maintainers of providers and consumers of our Go API.
- `clusterctl backup` has been removed.
- `MachineHealthCheckSuccededCondition` condition type has been removed.
- `CloneTemplate` and `CloneTemplateInput` has been removed.
- The option `--list-images` from `init` subcommand has been removed.

### API Changes

Expand Down