Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 CAPD: only ignore necessary kubeadm preflight errors #7842

Merged
merged 1 commit into from
Jan 4, 2023
Merged

🌱 CAPD: only ignore necessary kubeadm preflight errors #7842

merged 1 commit into from
Jan 4, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jan 4, 2023 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
With this PR CAPD only ignores SystemVerification and Swap preflight errors. The goal is to detect other preflight errors which affect other infra providers (e.g. ImagePull).

This should bring the test results of CAPD a bit closer to the ones of other infra providers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #7833

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 4, 2023
@sbueringer sbueringer mentioned this pull request Jan 4, 2023
Closed
4 tasks
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

@sbueringer
Copy link
Member Author

/hold

I might have to add some more prechecks based on latest results on #7829

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2023
@sbueringer
Copy link
Member Author

/hold cancel
Now I should have all relevant ones (all expected tests are green on #7829)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2023
@sbueringer
CAPD: only ignore necessary kubeadm preflight errors
a4c9bb8 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

fabriziopandini
fabriziopandini reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d60214dac699cdd0a86a64fe32ea55dd2005222

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit c5a4a9e into kubernetes-sigs:main Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 4, 2023
@sbueringer sbueringer deleted the pr-capd-preflight-errors branch January 5, 2023 05:58
@sbueringer
Copy link
Member Author

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 5, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7850

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/cherry-pick release-1.2

(cherry-picking to both to keep the test results in sync and avoid confusion if issues occur..)

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 5, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7852

In response to this:

/cherry-pick release-1.2

(cherry-picking to both to keep the test results in sync and avoid confusion if issues occur..)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @k8s-infra-cherrypick-robot @fabriziopandini