Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] ⚠️ KCP: block upgrade to versions with old registry, improve registry handling #7870

Merged

Conversation

sbueringer
Copy link
Member

handling

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
Manual cherry-pick of #7856

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

handling

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jan 9, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 9, 2023
@sbueringer sbueringer changed the title KCP: block upgrade to versions with old registry, improve registry [release-1.2] ⚠️ KCP: block upgrade to versions with old registry, improve registry handling Jan 9, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-2
  • /test pull-cluster-api-e2e-release-1-2
  • /test pull-cluster-api-test-mink8s-release-1-2
  • /test pull-cluster-api-test-release-1-2
  • /test pull-cluster-api-verify-release-1-2

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-2
  • /test pull-cluster-api-e2e-full-release-1-2
  • /test pull-cluster-api-e2e-informing-ipv6-release-1-2
  • /test pull-cluster-api-e2e-informing-release-1-2
  • /test pull-cluster-api-e2e-workload-upgrade-1-25-latest-release-1-2

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-2
  • pull-cluster-api-build-release-1-2
  • pull-cluster-api-e2e-informing-ipv6-release-1-2
  • pull-cluster-api-e2e-informing-release-1-2
  • pull-cluster-api-e2e-release-1-2
  • pull-cluster-api-test-mink8s-release-1-2
  • pull-cluster-api-test-release-1-2
  • pull-cluster-api-verify-release-1-2

In response to this:

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-release-1-2

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-release-1-2

@sbueringer
Copy link
Member Author

cc @fabriziopandini

@sbueringer
Copy link
Member Author

/retest

I'll try to reproduce locally in parallel

@sbueringer
Copy link
Member Author

I think it's a flake. Looks like a kube-apiserver Pod didn't come up for some reason. On my machine the same test was green

@sbueringer
Copy link
Member Author

/retest

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-release-1-2
/test pull-cluster-api-e2e-full-release-1-2

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-release-1-2

@sbueringer
Copy link
Member Author

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@sbueringer: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f67d8c36fc5c4f172dd4e269bb84ac695b8c0581

@k8s-ci-robot k8s-ci-robot merged commit 3d2a0a4 into kubernetes-sigs:release-1.2 Jan 10, 2023
@sbueringer sbueringer deleted the pr-kcp-registry-fix-1.2 branch January 10, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants