Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 🌱 ClusterClass & test/framework: consider replicas for control plane readiness #7924

Merged
merged 2 commits into from
Jan 16, 2023
Merged

[release-1.2] 🌱 ClusterClass & test/framework: consider replicas for control plane readiness #7924

merged 2 commits into from
Jan 16, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jan 16, 2023 •
edited
Loading

What this PR does / why we need it:
Manual cherry-pick of #7914

Doesn't contain all changes to the self-hosted test as the self-hosted test didn't contain an upgrade in release-1.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
ClusterClass: IsScaling now considers unavailableReplicas
2ff951f 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jan 16, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2023
@sbueringer sbueringer changed the title 🌱 ClusterClass & test/framework: consider replicas for control plane readiness [release-1.2] 🌱 ClusterClass & test/framework: consider replicas for control plane readiness Jan 16, 2023
@sbueringer
Copy link
Member Author

Will fix up

@sbueringer
test/framework: WaitForControlPlaneToBeReady now considers replicas
c817f5c 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-cc-improve-kcp-readiness-checks-1.2 branch from aedbc6f to c817f5c Compare January 16, 2023 10:41
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-2
  • /test pull-cluster-api-e2e-release-1-2
  • /test pull-cluster-api-test-mink8s-release-1-2
  • /test pull-cluster-api-test-release-1-2
  • /test pull-cluster-api-verify-release-1-2

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-2
  • /test pull-cluster-api-e2e-full-release-1-2
  • /test pull-cluster-api-e2e-informing-ipv6-release-1-2
  • /test pull-cluster-api-e2e-informing-release-1-2
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-latest-release-1-2

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-2
  • pull-cluster-api-build-release-1-2
  • pull-cluster-api-e2e-informing-ipv6-release-1-2
  • pull-cluster-api-e2e-informing-release-1-2
  • pull-cluster-api-e2e-release-1-2
  • pull-cluster-api-test-mink8s-release-1-2
  • pull-cluster-api-test-release-1-2
  • pull-cluster-api-verify-release-1-2

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

Manual cherry-pick. so I want to see the test results before merging

/hold
/test pull-cluster-api-e2e-full-release-1-2
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-release-1-2

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@fabriziopandini
Copy link
Member

/lgtm
pending CI

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17fa3f26af09e5bac060e92f66c8c7b9b87a466e

@sbueringer
Copy link
Member Author

sbueringer commented Jan 16, 2023 •
edited
Loading

/test pull-cluster-api-e2e-full-release-1-2

Let's see if it's just a flake

EDIT: probably unrelated, test failed because after patching MachinePool the Machines didn't come up (fast enough)

@sbueringer
Copy link
Member Author

All green

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 13595f8 into kubernetes-sigs:release-1.2 Jan 16, 2023
@sbueringer sbueringer deleted the pr-cc-improve-kcp-readiness-checks-1.2 branch January 16, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @fabriziopandini