-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 trivy: also build capd & test-extension images #7927
🐛 trivy: also build capd & test-extension images #7927
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
BTW - is there any way to run the trivy scan on PRs explicitly?
LGTM label has been added. Git tree hash: 01ac5bb3371b8475d9da5072e134f90cebe830bb
|
Not with our current GitHub action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All green on my fork after this PR: https://github.com/sbueringer/cluster-api/actions/runs/3930367553/jobs/6720770932 |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This PR ensures we also build all images on release-1.2 to avoid failing because of missing images
(https://github.com/kubernetes-sigs/cluster-api/actions/runs/3930140568/jobs/6719788260)
On newer branches
docker-build
builds all images.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #