-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add variable discovery to topology mutation proposal #7932
🌱 Add variable discovery to topology mutation proposal #7932
Conversation
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@killianmuldoon Thank you very much!
Overall, very nice.
I think this is a big step forward for topology mutation hooks!!
A few nits, otherwise lgtm from my side
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md
Show resolved
Hide resolved
d1da642
to
c215706
Compare
Thx! /lgtm /assign @fabriziopandini @ykakarap |
LGTM label has been added. Git tree hash: 19d461ef298feacc5be4340b8fbf4cb9d7f32dde
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
This will be an excellent improvement to the whole external patches story.
Great work @killianmuldoon
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md
Show resolved
Hide resolved
Great work! I'm really looking forward to see this implemented! |
c215706
to
4f1aadb
Compare
/lgtm |
LGTM label has been added. Git tree hash: 1746f371bc7a3872c0475656366c3db543ff715e
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add variable discovery hook and design details to the topology mutation proposal.
Related to: #6901