Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add variable discovery to topology mutation proposal #7932

Merged
merged 1 commit into from
Jan 27, 2023
Merged

🌱 Add variable discovery to topology mutation proposal #7932

merged 1 commit into from
Jan 27, 2023

Conversation

killianmuldoon
Copy link
Contributor

Add variable discovery hook and design details to the topology mutation proposal.

Related to: #6901

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2023
sbueringer
sbueringer reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@killianmuldoon Thank you very much!

Overall, very nice.

I think this is a big step forward for topology mutation hooks!!

A few nits, otherwise lgtm from my side

docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md Show resolved Hide resolved
docs/proposals/20220330-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/proposals/20220330-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/proposals/20220330-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/proposals/20220330-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/proposals/20220330-topology-mutation-hook.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!

/lgtm

/assign @fabriziopandini @ykakarap

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19d461ef298feacc5be4340b8fbf4cb9d7f32dde

ykakarap
ykakarap reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
This will be an excellent improvement to the whole external patches story.

Great work @killianmuldoon

docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md Outdated Show resolved Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-topology-mutation-hook.md Show resolved Hide resolved
@fabriziopandini
Copy link
Member

Great work! I'm really looking forward to see this implemented!
lgtm pending the above comments.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1746f371bc7a3872c0475656366c3db543ff715e

@fabriziopandini
Copy link
Member

/lgtm

@killianmuldoon killianmuldoon mentioned this pull request Jan 24, 2023
Closed
34 tasks
@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5c6fb4b into kubernetes-sigs:main Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 27, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@sbueringer sbueringer Awaiting requested review from sbueringer

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @fabriziopandini @ykakarap