Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix broken link to CAPZ experimental directory #7950

Merged

Conversation

killianmuldoon
Copy link
Contributor

Broken link due to AKS graduation in CAPZ - caught by the weekly markdown checker.

We might consider not having links to external repos like this if this is a maintenance burden - especially as line numbers can change pretty regularly, without the link checker understanding the change.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2023
@sbueringer
Copy link
Member

Thx for fixing it!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 631b391a641bc8a108c809141255c88b94a1a544

@sbueringer
Copy link
Member

/cherry-pick release-1.3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

sbueringer commented Jan 20, 2023

I'm backporting this to 1.3 and 1.2 to ensure the linkchecker is green on all supported branches.

@killianmuldoon
Copy link
Contributor Author

I've also opened a PR to ensure the link checker runs against supported branches. I guess updating these branches should be on the release team radar too.

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #7959

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@sbueringer: #7950 failed to apply on top of branch "release-1.2":

Applying: Fix broken link to CAPZ experimental directory
Using index info to reconstruct a base tree...
A	docs/proposals/20220725-managed-kubernetes.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): docs/proposals/20220725-managed-kubernetes.md deleted in HEAD and modified in Fix broken link to CAPZ experimental directory. Version Fix broken link to CAPZ experimental directory of docs/proposals/20220725-managed-kubernetes.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix broken link to CAPZ experimental directory
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

sbueringer commented Jan 20, 2023

Doc doesn't exist on release-1.2, so no need for a cherry-pick there.

I guess updating these branches should be on the release team radar too.

What do you mean with "update"?

@sbueringer
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants