Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use tenancy as filter in ownerReference test #7976

Merged
merged 1 commit into from
Jan 24, 2023
Merged

🐛 Use tenancy as filter in ownerReference test #7976

merged 1 commit into from
Jan 24, 2023

Conversation

killianmuldoon
Copy link
Contributor

This change cleans up the implementation introduced in #7973 using the tenancy concept exposed in the objectGraph returned by the call to discovery.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jan 23, 2023
Merged
@killianmuldoon killianmuldoon force-pushed the fix-ownerRef-secrets branch 2 times, most recently from 8125147 to 3ed7743 Compare January 23, 2023 17:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2023
@sbueringer
Copy link
Member

/lgtm
/assign @fabriziopandini

Nice catch @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a572afc5a2218ad71f1b2908186d7e0fe4b6943

fabriziopandini
fabriziopandini reviewed Jan 23, 2023
View reviewed changes
cmd/clusterctl/client/cluster/ownergraph.go Outdated
continue
}
// If the node is not a tenant do not add it to the ownerGraph.
if len(v.tenant) == 0 {
Copy link
Member

@fabriziopandini fabriziopandini Jan 23, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use graph.getMoveNodes to get the list of nodes already filtered with this criteria (so we can drop also this if)

In a future iteration, if necessary, we can also be explicit about which tenant we care about (one cluster, one clusterclass, probably one CRS), but for now it is ok to consider everything that should be moved because that's what is relevant in the test.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2023
fabriziopandini
fabriziopandini reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1603c5ba2e92987d7e112e2433a967aeb1e24ff8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

I think we need to re-run the netlify tests.

@vincepri
Copy link
Member

Kicked off a re-run from the GitHub UI 🤔 not sure if that did it though

@vincepri vincepri closed this Jan 23, 2023
@vincepri vincepri reopened this Jan 23, 2023
@vincepri
Copy link
Member

@killianmuldoon might have to rebase/force-push to re-trigger netlify

@sbueringer
Copy link
Member

Yup had the same on a different PR. Maybe it's this issue: https://answers.netlify.com/t/clear-cache-and-retry-for-deploy-preview-does-not-update-pull-request/81755

Didn't have any success with retries otherwise.

@k8s-ci-robot k8s-ci-robot merged commit f17502a into kubernetes-sigs:main Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@ykakarap ykakarap Awaiting requested review from ykakarap

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @vincepri @fabriziopandini